search

jenkinsci / discord-notifier-plugin

A post-build plugin that sends the build status to a Discord channel.
https://plugins.jenkins.io/discord-notifier/
MIT License
50 stars 25 forks source link

Improvements in Dynamic Fields #134

Closed eliaquimmauricio closed 1 month ago

eliaquimmauricio commented 7 months ago

Motivation: I had some problems to use links and environment variables in dynamic fields. For that, I did three modifications.

  1. Modified to split the dynamic fields into only two parts.
  2. Changed to accept environment variables in dynamic fields.
  3. Added “:” as part of the key to maintain the pattern.

Capture

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
chungbn commented 3 months ago

That's great! I really need this merge.