Check if client is running before updating proxy settings - Githubissues

jenkinsci / discord-notifier-plugin

A post-build plugin that sends the build status to a Discord channel.

https://plugins.jenkins.io/discord-notifier/

MIT License

50 stars 25 forks source link

Check if client is running before updating proxy settings #63

Closed Andy2003 closed 2 years ago

Andy2003 commented 2 years ago

This PR adds a check so the proxy settings of the Unirest client ore only changed if the client is not running

resolves #62

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Andy2003 commented 2 years ago

I tested this fix with our Jenkins (behind a proxy) and it is resolving the issue #62