jenkinsci / docker-agent

Jenkins agent (base image) and inbound agent Docker images
https://hub.docker.com/r/jenkins/inbound-agent/
MIT License
281 stars 230 forks source link

Code simplification: removal of default build `ARG` values when factorized #418

Open dduportal opened 1 year ago

dduportal commented 1 year ago

While working on #417 and #409 , I wondered if we could not simplify the "spread" of build arg values to factorized locations (1 for all Linux and one for all Windows).

The goal is to avoid any leftover when updating a JDK, Git or any important component.

@team-docker-packaging I remember the constraint of having a value for build-arg in the Dockerfile because of the DockerHub automated builds (major) and allowing users to build a standalone Dockerfile without the need for additional tools (minor).

But today (May 2023):

Any objection for a code cleanup to remove, only when specified through a centralize file(s) , the values from Dockerfile ?

timja commented 1 year ago

No objection to cleaning up the code

MarkEWaite commented 1 year ago

No objection from me. Thanks for the idea!