chore: align with docker-ssh-agent build process

[lemeurherve]

This PR aligns this repository with what have been implemented in https://github.com/jenkinsci/docker-ssh-agent/pull/415, all extracted changes mentioned in https://github.com/jenkinsci/docker-ssh-agent/pull/415#issuecomment-2169547751 and additional cleanup permitted by this change.

List of commits, notes and references to docker-ssh-agent issues and pull requests

chore: define jdks to build at a single place in docker bake (974969e)

• Cf https://github.com/jenkinsci/docker-ssh-agent/issues/418
• Cf https://github.com/jenkinsci/docker-ssh-agent/pull/419
• Also added missing jdk in "debian" bake target name for consistency

chore: add TestsDebug parameter (22934df)

• Cf https://github.com/jenkinsci/docker-ssh-agent/pull/396
• Supersede #828
• Detailed description from above closed pull request:

  
  > This PR introduces `-TestsDebug` parameter to build.ps1. > > With it we can use `-TestsDebug` parameter or `$env:TESTS_DEBUG` to improve Windows tests debugging: > - As it can be passed in the Jenkinsfile, it's easy now to activate it on a build replay instead of having to add a commit to switch debug on or off. > - This parameter can take the following values: > - empty/undefined: no additional debug (default value). > - `debug`: output every test command and stderr on top of every test. (Equivalent of setting `$quiet=$true` in the test_helpers "Run-Program" function currently) > - `verbose`: same as `debug` + output of stdout. > >

  Output (from docker-ssh-agent pull request):

  >
  > > With `.\build.ps1 test -TestsDebug 'debug'`: > > > With `.\build.ps1 test -TestsDebug 'verbose'`: > > >

  Similar to:

  • https://github.com/jenkinsci/docker-ssh-agent/pull/396

  Testing done

  Local tests + CI

  Replay with -TestsDebug set to "verbose" and only one Windows image type to validate the functionality:

  • diff

    ```diff --- old/Jenkinsfile +++ new/Jenkinsfile @@ -24,7 +24,7 @@ axes { axis { name 'IMAGE_TYPE' - values 'linux', 'nanoserver-1809', 'nanoserver-ltsc2019', 'nanoserver-ltsc2022', 'windowsservercore-1809', 'windowsservercore-ltsc2019', 'windowsservercore-ltsc2022' + values 'nanoserver-1809' } } stages { @@ -63,7 +63,7 @@ // If the tests are passing for Linux AMD64, then we can build all the CPU architectures sh 'docker buildx bake --file docker-bake.hcl linux' } else { - powershell '& ./build.ps1 test' + powershell '& ./build.ps1 test -TestsDebug verbose' } } } ```

chore: lint *.ps1 (19cce30)

• Single quotes instead of double quotes
• Add space after ifs

chore: add log output to Windows tests (57d5a57)

• Small QoL improvement

fix: implement docker calls as make targets (f96d882)

• Cf https://github.com/jenkinsci/docker-ssh-agent/issues/420
• Cf https://github.com/jenkinsci/docker-ssh-agent/pull/421

chore: shortens agentSelector comments (af17f85)

fix: remove interpolation in last sh and powershell calls (f48ef34)

chore: set bats formatter to junit (2bc7774)

• Adapted from docker-ssh-agent Makefile to get rid of the call to nodejs (and associated docker image pull) to convert bats output to junit
• Cf https://github.com/jenkinsci/docker-ssh-agent/pull/344

chore: use docker bake to generate docker compose file (4cc014e)

• Cf https://github.com/jenkinsci/docker-ssh-agent/issues/426
• Cf https://github.com/jenkinsci/docker-ssh-agent/pull/415
• Addition features added here:
  • Archive the docker compose files
  • New windowsagenttypes bake function to take care of the agent type ("agent" or "inbound-agent")
  • ~New windowsversiondigest bake function to take care of https://github.com/jenkinsci/docker-agent/pull/816~ (Removed in 1086ab17e1f9d0528314e8f10972963ede483e5e as follow-up of #833)
• This is one of the main commits to review

chore: get rid of build.sh and env.props (52b4455)

• All environment variables defined in build.sh are now defined in docker-bake.hcl
• env.props doesn't add any functionality that are used anymore AFAIK
• Only apply to this repository, no equivalent files in docker-ssh-agent

doc: adapt docker-ssh-agent's 'building' section to this repository (affb8e4)

• Commit importing original docker-ssh-agent "Building" section: 3ebdb13
• Should satisfy #830

(Docker images content remains untouched hence the "chore" label.)

Testing done

CI

Submitter checklist

• [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• [x] Ensure that the pull request title represents the desired changelog entry
• [x] Please describe what you did
• [x] Link to relevant issues in GitHub or Jira
• [x] Link to relevant pull requests, esp. upstream and downstream changes
• [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue