jenkinsci / docker-agent

Jenkins agent (base image) and inbound agent Docker images
https://hub.docker.com/r/jenkins/inbound-agent/
MIT License
282 stars 228 forks source link

chore(Windows): add `-TestsDebug` parameter to build.ps1 #828

Closed lemeurherve closed 1 month ago

lemeurherve commented 2 months ago

This PR introduces -TestsDebug parameter to build.ps1.

With it we can use -TestsDebug parameter or $env:TESTS_DEBUG to improve Windows tests debugging:

Output (from docker-ssh-agent pull request):
With `.\build.ps1 test -TestsDebug 'debug'`: image With `.\build.ps1 test -TestsDebug 'verbose'`: image

Similar to:

Testing done

Local tests + CI

Replay with -TestsDebug set to "verbose" and only one Windows image type to validate the functionality:

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
lemeurherve commented 2 months ago

Note: this change is also included in https://github.com/jenkinsci/docker-agent/pull/827, I created this distinct pull request to check outputs while working on it.

Prefer reviewing https://github.com/jenkinsci/docker-agent/pull/827 instead of this one.

lemeurherve commented 1 month ago

Closing in favor of https://github.com/jenkinsci/docker-agent/pull/827