jenkinsci / docker-plugin

Jenkins cloud plugin that uses Docker
https://plugins.jenkins.io/docker-plugin/
MIT License
490 stars 319 forks source link

chore: update jenkins.version in pom.xml to 2.452.4 #1106

Closed krisstern closed 1 month ago

krisstern commented 1 month ago

Updated the Jenkins version in "pom.xml" in preparation for a new release of the plugin.

Testing to be done

To use CI/CD configured on GitHub to run the required checks.

Submitter checklist

kirk-fitz commented 1 month ago

Hi @krisstern, why is this change needed/required for a new release of the plugin? Is the jenkins version not the minimum supported version? I believe @MarkEWaite has already done some the prepration for the next release of the plugin?

Kirk

MarkEWaite commented 1 month ago

Hi @krisstern, why is this change needed/required for a new release of the plugin? Is the jenkins version not the minimum supported version? I believe @MarkEWaite has already done some the prepration for the next release of the plugin?

We increment the minimum required Jenkins version based on the guidance in the "Choosing a minimum Jenkins version" page. In particular, since there was a security vulnerability fixed in 2.452.4, that makes it a good choice as a minimum Jenkins version. Versions older that 2.452.4 have the vulnerability. It is not strictly required for a new release, but is a good change to consider if we're planning a release for other reasons.

kirk-fitz commented 1 month ago

Ah okay thanks Mark, i did not notice the, minimum jenkins version page was updated, makes sense

On Mon 14 Oct 2024, 02:52 Mark Waite, @.***> wrote:

Hi @krisstern https://github.com/krisstern, why is this change needed/required for a new release of the plugin? Is the jenkins version not the minimum supported version? I believe @MarkEWaite https://github.com/MarkEWaite has already done some the prepration for the next release of the plugin?

We increment the minimum required Jenkins version based on the guidance in the "Choosing a minimum Jenkins version" page https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/. In particular, since there was a security vulnerability fixed in 2.452.4, that makes it a good choice as a minimum Jenkins version. Versions older that 2.452.4 have the vulnerability. It is not strictly required for a new release, but is a good change to consider if we're planning a release for other reasons.

— Reply to this email directly, view it on GitHub https://github.com/jenkinsci/docker-plugin/pull/1106#issuecomment-2409673926, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKA4AWEQFPNJRLJUITPYPIDZ3MPVBAVCNFSM6AAAAABP2PGFA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGY3TGOJSGY . You are receiving this because you commented.Message ID: @.***>