jenkinsci / docker-plugin

Jenkins cloud plugin that uses Docker
https://plugins.jenkins.io/docker-plugin/
MIT License
490 stars 319 forks source link

Use same version in BOM as is declared for plugin #1114

Closed MarkEWaite closed 3 weeks ago

MarkEWaite commented 3 weeks ago

Use same version in BOM as is declared for plugin

Previously the plugin required Jenkins 2.452.4 but only used plugin BOM dependencies from 2.440.x.

Also removes the unnecessary declaration of the httpcomponents-client-5 plugin version since the plugin BOM now includes the correct version.

Replaces pull request:

Testing done

Confirmed that mvn dependency:tree reports the same version of httpcomponents-client-5 plugin from the plugin BOM as is currently delivered to users.

Confirmed that automated tests pass.

Submitter checklist

MarkEWaite commented 3 weeks ago

@gounthar I saw that you approved #1113 . Are you OK with using this as a replacement for it?

gounthar commented 3 weeks ago

Sure thing, Mark, thanks for asking. 🤗