magnayn
commented
9 years ago Hmm. It looks a touch broken. I suspect that when we ported over to docker-java, the different API wasn't converted correctly.
As an aside, docker has a very confus(ed,ing) terminology around labelling, tags and namespaces, which doesn't help.
Looking at it, I think it's also broken just below where
if (getJobProperty().pushOnSuccess) {
client.pushImageCmd(tagToken).exec();
}became changed to
if (getJobProperty().pushOnSuccess) {
client.pullImageCmd(tagToken).exec(new PullImageResultCallback()).awaitSuccess();
}Which looks completely wrong to me.
If you're near a compiler, you could replace the entire block with something like
if (!Strings.isNullOrEmpty(tagToken)) {
final NameParser.ReposTag reposTag = NameParser.parseRepositoryTag(tagToken);
final String commitTag = isEmpty(reposTag.tag) ? "latest" : reposTag.tag;
getClient().tagImageCmd(tag_image, reposTag.repos, commitTag).withForce().exec();
addJenkinsAction(tagToken);
if (getJobProperty().pushOnSuccess) {
client.pushImageCmd(tagToken).exec(new PushImageResultCallback()).awaitSuccess();
}
}Which ought to do what is needed.
jphelion
Hi, We are having a problem with adding additional tags. We try to commit, add additional tags and then push. Commit works fine but when additional tags are added a NPE is thrown instead.
I did a slight modification in DockerSlave.java to this logger:
I made the logger to also print the exception:
This gave more insight to what was going on:
No other changes were made to the code.
Possible cause:
After going through the code at the point where the error was caught, i found this:
DockerSlave.java:
Is the null intentional? If so how can we get tagging to work again on our project?
This method call takes the null all the way to docker-javas TagImageCmdImpl.java and to this part of the code:
and that goes to here in the same file:
Then the checkNotNull method throws a NPE, because null was given as the repository parameter.
This was tested on a localhost jenkins, docker and with evarga/jenkins-slave image.
Full logs
with modified "Could not add additional tags" line:
Installed Plugins:
Cloud configuration block:
Docker:
Manage Old Data:
Nothing
To reproduce:
Install plugin and start own jenkins on localhost, then pull everga/jenkins and push it to own registry that is set up on localhost. Configure the plugin to use http://localhost:4243 as docker registry url and pushed evarga/jenkins image as the base image. Create freestyle job and use the "Additional tag to add" field, check the "Push on successful build" and build. We are behind a company proxy, if that affects the behavior of the plugin somehow.