Closed rdica closed 3 years ago
I've made a PR (#835) that I should fix the bug (I think).
Unfortunately, its build is failing for what I believe to be unrelated issues (DockerNodeStepTest
's toolInstall()
test sadly depends on external servers and this seems to be failing.
If you're able to take the PR and build it yourself, please do so (as the fix for the test might take a while) and let me know if it works for you.
@pjdarton I will try it tonight.
@pjdarton My apologies, these plugins are jar files, i dont know how to build one in order to test your PR.
I've made another PR (#836) which seems to fix the DockerNodeStepTest
unit test failure ... but I'm wary of merging that because it involves changes to the pom.xml file which I'm not 100% confident are correct (as I don't fully understand those files).
Once we have a fix for DockerNodeStepTest
merged, the other PR should then rebuild and pass the tests, resulting in a .hpi file build artefact that you can download, install into your Jenkins server (via the "advanced" tab on the plugin management page) and then test.
+1
@pjdarton : Hey Peter, we have some issues now as our Jenkins Master cannot connect to the Jenkins Agents running in our "docker cloud". What is missing at the moment to get your PR merged? Maybe i can help with something?
It was blocked pending testing. Since then, it stopped merging (due to other changes in the master branch), so I've now fixed that and made further changes to the PR that seem to allow it to build & work again ... so now it needs testing "for real".
If you're in a position where you need this fix, you're in a perfect position to test this fix 😁 So go to #835, scroll to the end, tell it to "Show all checks", find the "Deployed to incrementals" step, download the .hpi file from there and then, on your own Jenkins instance, go to Manage Jenkins -> Manage Plugins -> Advanced and upload the .hpi file to there.
If that fixes it for you, comment in #835 telling everyone of your test results - once I'm confident that it all works then I'll merge it in.
Hey Peter, the fix works for me. I have updated the SSH Agent plugin to 1.32.0 and also installed the docker-plugin HPI file from here https://repo.jenkins-ci.org/incrementals/io/jenkins/docker/docker-plugin/1.2.3-rc974.720c6519100d/
From my site it looks good.
PR was merged yesterday and a release (version 1.2.3) done today. I'm going to mark the issue "closed" as I believe that should fix it... but if anyone can prove otherwise please do say so.
Version report
Jenkins and plugins versions report:
Reproduction steps
Results
Expected result:
Docker container deploys, build is run on container, container is destroyed on completion.
Actual result:
Docker container deploys but SSH connection fails so build agent does not get deployed, job fails.
System log: