jenkinsci / docker-plugin

Jenkins cloud plugin that uses Docker
https://plugins.jenkins.io/docker-plugin/
MIT License
490 stars 319 forks source link

Do not use `<h1>` in summary #968

Closed basil closed 1 year ago

basil commented 1 year ago

The <h1> tag in the summary looked off and seemed to only be there to facilitate re-use of the summary in the full view, which was ripped out recently in #911. I looked at other summaries in popular plugins and none of them had headings at all, let alone <h1> which is surely inappropriate for a summary item. To test this I viewed the page before and after; before it had an ugly heading in the middle of the page. It looked reasonable after.

CC @jenkinsci/sig-ux