search

jenkinsci / docker-ssh-agent

Docker image for Jenkins agents connected over SSH
https://hub.docker.com/repository/docker/jenkins/ssh-agent
MIT License
179 stars 175 forks source link

There is a mix of `make` and `docker` calls in the Jenkinsfile #420

Closed lemeurherve closed 2 months ago

lemeurherve commented 3 months ago

Jenkins and plugins versions report

N/A

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A

Reproduction steps

  1. Notice that there is a mix of make and docker calls in the Jenkinsfile.

Expected Results

The calls to either make or docker are consistent and justified.

Actual Results

The first call to docker makes sense as it's specific to our CI environment, having it outside the Makefile doesn't prevent contributors to build images on their own. https://github.com/jenkinsci/docker-ssh-agent/blob/2985d6ff8ffac453125577c71a25268002e320c5/Jenkinsfile#L48-L49

The next ones don't though, they should be calls to make targets that can also be used by contributors on their own. https://github.com/jenkinsci/docker-ssh-agent/blob/2985d6ff8ffac453125577c71a25268002e320c5/Jenkinsfile#L61-L64 https://github.com/jenkinsci/docker-ssh-agent/blob/2985d6ff8ffac453125577c71a25268002e320c5/Jenkinsfile#L87-L89

Anything else?

No response

Are you interested in contributing a fix?

Yes:

lemeurherve commented 2 months ago

Confirmed working with https://github.com/jenkinsci/docker-ssh-agent/releases/tag/5.41.0 built completed on trusted.ci.jenkins.io