chore: remove unused build.ps1 `Build` parameter and commented line - Githubissues

jenkinsci / docker-ssh-agent

Docker image for Jenkins agents connected over SSH

https://hub.docker.com/repository/docker/jenkins/ssh-agent

MIT License

187 stars 175 forks source link

chore: remove unused build.ps1 `Build` parameter and commented line #425

Closed lemeurherve closed 4 months ago

lemeurherve commented 4 months ago

This PR removes this unused build.ps1 Build parameter: https://github.com/jenkinsci/docker-ssh-agent/blob/bad064233ecebab858236cd141e39b06b5fdbf98/build.ps1#L2-L5

And a commented line that I should have removed from https://github.com/jenkinsci/docker-ssh-agent/pull/289 when adapting from docker-agent build process (where setting this path is needed as there is a tests suite per type of agent): https://github.com/jenkinsci/docker-ssh-agent/blob/bad064233ecebab858236cd141e39b06b5fdbf98/build.ps1#L100

Testing done

Local test + CI

Submitter checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue