search

jenkinsci / docker-ssh-agent

Docker image for Jenkins agents connected over SSH
https://hub.docker.com/repository/docker/jenkins/ssh-agent
MIT License
187 stars 175 forks source link

Revert "fix: pin windowsservercore-ltsc2019 to April 2024 release" #435

Closed lemeurherve closed 3 months ago

lemeurherve commented 3 months ago

Reverts jenkinsci/docker-ssh-agent#433

This PR removes the Windows Server Core version pinning so we can use its last image version published today as base instead of the one from April 2024.

From https://github.com/microsoft/Windows-Containers/issues/493#issuecomment-2219090926:

The updated images released as part of the July 2024 security update today include the fix for this issue.

Confirmed by building this from another host than Windows:

# OK with docker buildx build --platform windows/amd64 -t test .
FROM --platform=windows/amd64 mcr.microsoft.com/windows/servercore:ltsc2019 AS latest
COPY README.md README.md

# OK with docker buildx build --platform windows/amd64 -t test .
FROM --platform=windows/amd64 mcr.microsoft.com/windows/servercore:ltsc2019@sha256:41f42aa4ad39d85e4d30642b8111ca6454ca2275f188f012934b9afbaf63a647 AS latestdigest
COPY README.md README.md

Same as:

Ref: