Use `java hudson.remoting.jnlp.Main` not `java -jar agent.jar`

jenkinsci / docker-swarm-plugin

Jenkins plugin which allows to add a Docker Swarm as a cloud agent provider

https://plugins.jenkins.io/docker-swarm/

MIT License

55 stars 47 forks source link

Use `java hudson.remoting.jnlp.Main` not `java -jar agent.jar` #125

Closed jglick closed 11 months ago

jglick commented 11 months ago

Allows agents to connect to a Jenkins controller using a non-public URL after https://github.com/jenkinsci/jenkins/pull/4839. https://github.com/KostyaSha/yet-another-docker-plugin/issues/288#issuecomment-687212127 gives some background.

Roemer commented 11 months ago

Thanks, seems to make sense.

jglick commented 9 months ago

As of https://github.com/jenkinsci/remoting/pull/677 java -classpath agent.jar hudson.remoting.jnlp.Main -headless ran be simplified to just java -jar agent.jar. Also the two positional arguments are better made explicit as -secret and -name, respectively.