search

jenkinsci / docker-swarm-plugin

Jenkins plugin which allows to add a Docker Swarm as a cloud agent provider
https://plugins.jenkins.io/docker-swarm/
MIT License
55 stars 47 forks source link

[FIX] Fix NullPointerException when retrieving TimeoutMinutes from DockerSwarmCloud #94

Closed Polpetta closed 3 years ago

Polpetta commented 3 years ago

There was a NullPointerException when retrieving DockerSwarmCloud.get().getTimeoutMinutes(). This behaviour has been fixed with the use of an Optional. If the instance is null, then a default value is used instead. Finally, a typo has been fixed and proper Java8 notation has been used for props() method.

This closes #93

Polpetta commented 3 years ago

Additional note: I tested this on a test Jenkins instance and it seems to solve the problem, no more NPE appears.

Roemer commented 3 years ago

Thank you for you fix!

markixy commented 8 months ago

i still see this error.

[ERROR] [12/29/2023 16:49:22.691] [swarm-plugin-akka.actor.default-dispatcher-47] [akka://swarm-plugin/user/reset-stuck-builds-actor] null
java.lang.NullPointerException
    at org.jenkinsci.plugins.docker.swarm.ResetStuckBuildsInQueueActor.resetStuckBuildsInQueue(ResetStuckBuildsInQueueActor.java:36)
    at org.jenkinsci.plugins.docker.swarm.ResetStuckBuildsInQueueActor.lambda$createReceive$0(ResetStuckBuildsInQueueActor.java:27)
    at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:24)
    at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:20)
    at scala.PartialFunction.applyOrElse(PartialFunction.scala:127)
    at scala.PartialFunction.applyOrElse$(PartialFunction.scala:126)
    at akka.japi.pf.UnitCaseStatement.applyOrElse(CaseStatements.scala:20)
    at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:175)
    at akka.actor.Actor.aroundReceive(Actor.scala:539)
    at akka.actor.Actor.aroundReceive$(Actor.scala:537)
    at akka.actor.AbstractActor.aroundReceive(AbstractActor.scala:227)
    at akka.actor.ActorCell.receiveMessage(ActorCell.scala:612)
    at akka.actor.ActorCell.invoke(ActorCell.scala:581)
    at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:268)
    at akka.dispatch.Mailbox.run(Mailbox.scala:229)
    at akka.dispatch.Mailbox.exec(Mailbox.scala:241)
    at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
    at akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
    at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
    at akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)

context jenkins2.426.2 just install “Docker Swarm Plugin 1.11” plugin，swarm cloud has not been yet configured