jenkinsci / docker

Docker official jenkins repo
https://hub.docker.com/r/jenkins/jenkins
MIT License
6.63k stars 4.51k forks source link

Also publish to GitHub container registry #1140

Open timja opened 3 years ago

timja commented 3 years ago

Any thoughts?

I've done an experiment here: https://github.com/timja/jenkins-ci.org-docker/pkgs/container/jenkins

see https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

Steps taken:

The main benefit I see is there's pull metrics per tag. It amazes me that docker hub does not provide this =/. I want to know if anyone actually uses e.g. centos or windows tags.

cc @dduportal @MarkEWaite @slide @olblak

olblak commented 3 years ago

I wouldn't leave dockerhub because well it's still the default place to go but I don't see any objection to push images to ghcr as well. I am using it for updatecli from here and it's working great

slide commented 3 years ago

I also think we shouldn't leave dockerhub, people look there first for images. I think ALSO publishing to ghcr would be fine.

MarkEWaite commented 3 years ago

I think publishing to GitHub container registry is a great idea in addition to Dockerhub.

dduportal commented 3 years ago

+1 on this: with the recent addition of docker buildx bake, it should be easy on the pipeline side.

@timja since I recently got warned by GitHub that I'm consuming too much space, could you check the limitations (size/API rate) on the GitHub that we would have if we do so?

timja commented 3 years ago

free for public packages, and doesn't appear to be any limits: https://docs.github.com/en/billing/managing-billing-for-github-packages/about-billing-for-github-packages#about-billing-for-github-packages

olblak commented 3 years ago

I am not aware of any limits and I would definitely be in favor to publish on ghrc.io