jenkinsci / docker

Docker official jenkins repo
https://hub.docker.com/r/jenkins/jenkins
MIT License
6.65k stars 4.52k forks source link

chore(updatecli): add manifests for hadolint & shellcheck in tools scripts #1858

Closed lemeurherve closed 5 months ago

lemeurherve commented 5 months ago

This PR adds updatecli manifests for keeping the versions of hadolint & shellcheck up to date in the ./tools scripts.

Testing done

Local tests + CI

Dry run outputs: #### hadolint ``` ✔ GitHub release version "v2.12.0" found matching pattern "*" of kind "semver" CHANGELOG: ---------- Release published on the 2022-11-09 18:20:48 +0000 UTC at the url https://github.com/hadolint/hadolint/releases/tag/v2.12.0 **Full Changelog**: https://github.com/hadolint/hadolint/compare/v2.11.0...v2.12.0 * Try a newer GHC version for valid MacOS Ventura builds TARGETS ======== updateVersion ------------- **Dry Run enabled** ✔ - all contents from 'file' and 'files' combined already up to date ``` #### shellcheck > "tools/shellcheck" updated with [dry run] content "koalaman/shellcheck:v0.10.0 " ```diff --- tools/shellcheck +++ tools/shellcheck @@ -3,4 +3,4 @@ exec docker run --rm \ -w "${PWD}" \ -v "${PWD}:${PWD}" \ - koalaman/shellcheck:v0.9.0 "$@" + koalaman/shellcheck:v0.10.0 "$@" ```
### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
MarkEWaite commented 5 months ago

The updatecli dry run looks good. Merging since the other tests in the CI job do not evaluate the updatecli changes.