jenkinsci / docker

Docker official jenkins repo
https://hub.docker.com/r/jenkins/jenkins
MIT License
6.73k stars 4.55k forks source link

chore: add support for the artifact ignore list #1862

Closed lemeurherve closed 7 months ago

lemeurherve commented 7 months ago

This PR adds support for the artifact ignore list defined at https://github.com/jenkins-infra/update-center2/blob/master/resources/artifact-ignores.properties to prevent publishing images of releases we choose to not publish.

Ref:

Testing done

Local tests.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
lemeurherve commented 7 months ago

@daniel-beck do you think it still worth introducing this?

daniel-beck commented 7 months ago

Don't we create new releases based on tags now? Seems like not (re)creating a tag addresses the problem. Previously, we'd list the newest N releases multiple times per day, and ensure all of them have Docker images.

MarkEWaite commented 7 months ago

I agree with @daniel-beck . I don't think we need this addition because we only build when a new annotated tag is detected.

lemeurherve commented 7 months ago

Thanks for your comments!

Closing this pull request and #946.