The !proxy.equals(Proxy.NO_PROXY) check does not appear to catch all cases that it should. Explicitly pass the Jenkins No Proxy list through to the client configuration to handle the cases that get past that check.
Testing done
Tested on our live instance with our No Proxy list and confirmed traffic wasn't being sent to the proxy as expected.
Submitter checklist
[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
Fixes #441
The
!proxy.equals(Proxy.NO_PROXY)
check does not appear to catch all cases that it should. Explicitly pass the Jenkins No Proxy list through to the client configuration to handle the cases that get past that check.Testing done
Tested on our live instance with our No Proxy list and confirmed traffic wasn't being sent to the proxy as expected.
Submitter checklist