jenkinsci / ec2-fleet-plugin

The EC2 Fleet plugin launches EC2 instances as worker nodes for Jenkins CI server, automatically scaling the capacity with the load.
https://plugins.jenkins.io/ec2-fleet/
Apache License 2.0
111 stars 81 forks source link

Fix NoProxy configuration #442

Open BradyShober opened 6 months ago

BradyShober commented 6 months ago

Fixes #441

The !proxy.equals(Proxy.NO_PROXY) check does not appear to catch all cases that it should. Explicitly pass the Jenkins No Proxy list through to the client configuration to handle the cases that get past that check.

Testing done

Tested on our live instance with our No Proxy list and confirmed traffic wasn't being sent to the proxy as expected.

Submitter checklist

jakauppila commented 5 months ago

Any chance of this being merged? It would be useful for us.