search

jenkinsci / eiffel-broadcaster-plugin

Jenkins plugin to Broadcast Eiffel events from Jenkins.
https://plugins.jenkins.io/eiffel-broadcaster/
MIT License
11 stars 12 forks source link

Make meta.source.domainId configurable #41

Open magnusbaeck opened 3 years ago

magnusbaeck commented 3 years ago

Dependencies

None.

Feature Request

Some sites might use the domain feature of the Eiffel protocol, exposed in the meta.source.domainId attribute. The value of that attribute should be configurable for outbound events sent by this plugin. Let's start with a global configuration without ruling out the possibility of per-job overrides.

ashwin1596 commented 2 months ago

Hi,

I am interested in working on this issue and believe it will help me learn more about the codebase.

Could you please confirm if I can start working on it?

Thank you!

magnusbaeck commented 2 months ago

Thanks for your interest! You can certainly start looking into this one, but there's an unstated dependency to #62. Not all Eiffel editions support the meta.source.domainId attribute, so setting the attribute needs to be dependent on the user selecting a sufficiently new Eiffel edition compatibility level. #62 is at the top of my list of things to work on, but don't expect it to be completed in the next month.

That aside, this will be pretty straight forward. You'll need to add a text field in the configuration where the administrator can select the domainId to add to each outbound event. Since this should be tied to the selected edition, it should be added to the upcoming config.groovy or config.jelly that'll be used for edition-specific configuration. Once that's in place, the event factory that's being added in #117 can be updated to set the meta.source.domainId attribute based on the configuration.

I realize that the "good first issue" label is a bit misleading. It's a fairly simple issue to complete, but it depends on multiple things to get in first.

FYI, I'm just about to leave on a one-week off-grid vacation.