jenkinsci / extension-filter-plugin

https://plugins.jenkins.io/extension-filter/
MIT License
2 stars 7 forks source link

Build plugin on ci.jenkins.io #2

Closed alecharp closed 6 years ago

alecharp commented 6 years ago

@reviewbybees @batmat

batmat commented 6 years ago

@ndeloof can you please merge this?

alecharp commented 6 years ago

@oleg-nenashev @batmat I removed the shebang as requested.

batmat commented 6 years ago

@oleg-nenashev if you agree with the content now, can you please consider merging?

I've had off-the-band feedback from @ndeloof who's on holiday but agree we merge this.

oleg-nenashev commented 6 years ago

Merging according to the comment

oleg-nenashev commented 6 years ago

@batmat @alecharp Master build passed. The plugin still needs a facelift, but it should be operational in general

batmat commented 6 years ago

Did the plugin-pom bump in https://github.com/jenkinsci/extension-filter-plugin/pull/3 @oleg-nenashev @alecharp FYI.

batmat commented 6 years ago

@alecharp do/did you intend to take over maintenance of this plugin? Thanks!

alecharp commented 6 years ago

I wasn't planing to. I'm just wondering if this is required, but if noone volunteer, I can do it.

batmat commented 6 years ago

@alecharp we will need it at least to release the current PRs that are, or are going to, be merged. For instance my ongoing #3.

I can do it too, just tell me if you're interested. Thanks!