Resolve default value breaking empty context form round trip

jenkinsci / extension-filter-plugin

https://plugins.jenkins.io/extension-filter/

MIT License

2 stars 7 forks source link

Resolve default value breaking empty context form round trip #60

Closed sridamul closed 6 months ago

sridamul commented 6 months ago

Closes #49

I am not sure about removing the default value in the context field. I thought one can easily understand about context with the help of help-context.html

cc: @jonesbusy

jonesbusy commented 6 months ago

Hi,

Looks good to me and thanks for adding a test.

Did you also do some interactive testing ? The plugin lacks also coverage to be 100% confident of the changes

Thanks

sridamul commented 6 months ago

~Ok! Let me do that in the following PR~

Oops sorry, It seems like I misunderstood your comment

sridamul commented 6 months ago

Did you also do some interactive testing ?

Yes, I did and seems to work fine as before