search

jenkinsci / extension-filter-plugin

https://plugins.jenkins.io/extension-filter/
MIT License
2 stars 7 forks source link

Modernize Extension and avoid Guice circular dependency #64

Closed sridamul closed 8 months ago

sridamul commented 8 months ago

Closes #54

Testing:

https://github.com/jenkinsci/extension-filter-plugin/assets/107404972/237cde9a-49ce-4634-91db-dabfca8fe41b

https://github.com/jenkinsci/extension-filter-plugin/assets/107404972/973d148d-a3a3-41f1-a513-4b6e3df3060c

cc: @jonesbusy

sridamul commented 8 months ago

We need to test disabling an extension (for example freestyle job) and see if they persist after a reload and reboot. Perhaps also a test with RestartableJenkinsRule can validate this.

Hey @jonesbusy right now I am exploring more about Jenkins testing, I will try to implement this in a follow-up PR

jonesbusy commented 8 months ago

Thanks for your PR! Looks good so far, thank you so much!

jonesbusy commented 8 months ago

I've tested this PR also on my production Jenkins. It works like a charm.

Also it fixes that Jenkins doesn't need to be reloaded or restarted after changing the extension filter (Not sure why, but probably it's now working. I was suprised to see it working on your video).

Thanks again

jonesbusy commented 8 months ago

Possible cause of https://github.com/jenkinsci/extension-filter-plugin/issues/65