jenkinsci / generic-event-plugin

https://plugins.jenkins.io/generic-event/
Apache License 2.0
18 stars 10 forks source link

in the "source" field comes the url of the parent and not the item itself #7

Closed ant1dot closed 1 year ago

ant1dot commented 2 years ago

Jenkins and plugins versions report

Environment ```Jenkins: 2.361.1 OS: Linux - 3.10.0-327.28.3.el7.x86_64 --- PrioritySorter:4.1.0 ace-editor:1.1 active-directory:2.26 allure-jenkins-plugin:2.30.2 ant:481.v7b_09e538fcca antisamy-markup-formatter:2.7 apache-httpcomponents-client-4-api:4.5.13-138.v4e7d9a_7b_a_e61 authentication-tokens:1.4 aws-credentials:191.vcb_f183ce58b_9 aws-java-sdk-ec2:1.12.287-357.vf82d85a_6eefd aws-java-sdk-minimal:1.12.287-357.vf82d85a_6eefd bootstrap4-api:4.6.0-5 bootstrap5-api:5.2.0-3 bouncycastle-api:2.26 branch-api:2.1046.v0ca_37783ecc5 build-blocker-plugin:1.7.8 build-environment:1.7 build-monitor-plugin:1.13+build.202205140447 build-name-setter:2.2.0 build-pipeline-plugin:1.5.8 build-timeout:1.24 buildtriggerbadge:251.vdf6ef853f3f5 built-on-column:1.1 caffeine-api:2.9.3-65.v6a_47d0f4d1fe checks-api:1.7.5 cloudbees-folder:6.758.vfd75d09eea_a_1 command-launcher:90.v669d7ccb_7c31 commons-lang3-api:3.12.0-36.vd97de6465d5b_ conditional-buildstep:1.4.2 config-file-provider:3.11.1 copyartifact:1.47 credentials:1143.vb_e8b_b_ceee347 credentials-binding:523.vd859a_4b_122e6 dashboard-view:2.447.vda_124dd35f11 display-url-api:2.3.6 docker-commons:1.21 docker-workflow:521.v1a_a_dd2073b_2e durable-task:500.v8927d9fd99d8 echarts-api:5.3.3-1 email-ext:2.91 embeddable-build-status:255.va_d2370ee8fde envfile:1.2 envinject:2.875.v9b_9e962da_a_ec envinject-api:1.199.v3ce31253ed13 environment-script:1.2.6 external-monitor-job:203.v683c09d993b_9 ez-templates:1.3.5 favorite:2.4.1 font-awesome-api:6.1.2-1 generic-event:39.v39aadf98ff06 git:4.12.1 git-client:3.12.0 git-server:99.va_0826a_b_cdfa_d gitlab-plugin:1.5.35 greenballs:1.15.1 handlebars:3.0.8 handy-uri-templates-2-api:2.1.8-22.v77d5b_75e6953 htmlpublisher:1.31 http_request:1.16 instance-identity:116.vf8f487400980 ionicons-api:24.va_745a_b_a_97fc3 ivy:2.2 jackson2-api:2.13.3-285.vc03c0256d517 jakarta-activation-api:2.0.1-1 jakarta-mail-api:2.0.1-1 javadoc:226.v71211feb_e7e9 javax-activation-api:1.2.0-4 javax-mail-api:1.6.2-7 jaxb:2.3.6-1 jdk-tool:55.v1b_32b_6ca_f9ca jenkins-multijob-plugin:623.v03401733c9a_9 jersey2-api:2.37-1 jira:3.8 jjwt-api:0.11.5-77.v646c772fddb_0 jobConfigHistory:1176.v1b_4290db_41a_5 jquery:1.12.4-1 jquery-detached:1.2.1 jquery3-api:3.6.0-4 jsch:0.1.55.61.va_e9ee26616e7 junit:1119.1121.vc43d0fc45561 ldap:2.12 lockable-resources:2.16 mailer:438.v02c7f0a_12fa_4 mapdb-api:1.0.9-28.vf251ce40855d matrix-auth:3.1.5 matrix-project:785.v06b_7f47b_c631 maven-plugin:3.19 metrics:4.2.10-389.v93143621b_050 mina-sshd-api-common:2.9.1-44.v476733c11f82 mina-sshd-api-core:2.9.1-44.v476733c11f82 momentjs:1.1.1 monitoring:1.91.0 multi-branch-project-plugin:0.7 multibranch-action-triggers:1.8.6 multiple-scms:0.8 nodelabelparameter:1.11.0 notification:1.15 okhttp-api:4.9.3-108.v0feda04578cf pam-auth:1.10 parameterized-trigger:2.45 periodicbackup:1.9 permissive-script-security:0.7 pipeline-build-step:2.18 pipeline-github-lib:38.v445716ea_edda_ pipeline-graph-analysis:195.v5812d95a_a_2f9 pipeline-groovy-lib:612.v84da_9c54906d pipeline-input-step:449.v77f0e8b_845c4 pipeline-milestone-step:101.vd572fef9d926 pipeline-model-api:2.2114.v2654ca_721309 pipeline-model-declarative-agent:1.1.1 pipeline-model-definition:2.2114.v2654ca_721309 pipeline-model-extensions:2.2114.v2654ca_721309 pipeline-multibranch-defaults:2.1 pipeline-rest-api:2.24 pipeline-stage-step:296.v5f6908f017a_5 pipeline-stage-tags-metadata:2.2114.v2654ca_721309 pipeline-stage-view:2.24 pipeline-utility-steps:2.13.0 plain-credentials:139.ved2b_9cf7587b plugin-util-api:2.17.0 popper-api:1.16.1-3 popper2-api:2.11.6-1 pubsub-light:1.17 python:1.3 rebuild:1.34 resource-disposer:0.20 run-condition:1.5 saferestart:0.3 scm-api:621.vda_a_b_055e58f7 script-security:1183.v774b_0b_0a_a_451 slack:616.v03b_1e98d13dd snakeyaml-api:1.31-84.ve43da_fb_49d0b sse-gateway:1.26 ssh-credentials:305.v8f4381501156 ssh-slaves:2.846.v1b_70190624f5 sshd:3.249.v2dc2ea_416e33 strict-crumb-issuer:2.1.0 structs:324.va_f5d6774f3a_d subversion:2.16.0 text-finder:1.20 thinBackup:1.10 timestamper:1.20 token-macro:308.v4f2b_ed62b_b_16 trilead-api:2.72.v2a_3236754f73 uno-choice:2.6.4 variant:59.vf075fe829ccb view-job-filters:2.3 windows-slaves:1.8.1 workflow-aggregator:590.v6a_d052e5a_a_b_5 workflow-api:1192.v2d0deb_19d212 workflow-basic-steps:994.vd57e3ca_46d24 workflow-cps:2759.v87459c4eea_ca_ workflow-cps-global-lib:588.v576c103a_ff86 workflow-durable-task-step:1199.v02b_9244f8064 workflow-job:1232.v5a_4c994312f1 workflow-multibranch:716.vc692a_e52371b_ workflow-remote-loader:1.5 workflow-scm-step:400.v6b_89a_1317c9a_ workflow-step-api:639.v6eca_cd8c04a_a_ workflow-support:838.va_3a_087b_4055b ws-cleanup:0.43 ```

What Operating System are you using (both controller, and any agents involved in the problem)?

macos

Reproduction steps

create / update job

Expected Results

return url item

Actual Results

return parent url item

Anything else?

No response

ant1dot commented 2 years ago

@JohnNiang can you please explain why this solution was chosen? we can fix this feature and start returning element url or add another url field

JohnNiang commented 2 years ago

Thank you for reaching out here!

IMO, this source stands represents the trigger source of the event in Jenkins. As for which Jenkins triggerred the current event, it may belong to metadata information. Would it solve your problem if we could add some metadata information to the event?

ant1dot commented 2 years ago

@JohnNiang if we start returning the url of the object, not the parent, then yes. we can do pr, let's agree where to add the field? json['url'] json['data']['url'] ?