Add new event type for cases when job was moved or renamed

jenkinsci / generic-event-plugin

https://plugins.jenkins.io/generic-event/

Apache License 2.0

18 stars 10 forks source link

Add new event type for cases when job was moved or renamed #9

Closed nikitakasatkin44 closed 1 year ago

nikitakasatkin44 commented 1 year ago

Added new event type for cases when job was moved or renamed.

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[ ] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

ant1dot commented 1 year ago

Hello @JohnNiang! Can you give feedback or accept pr please?

ant1dot commented 1 year ago

@JohnNiang can you accept pr please?

JohnNiang commented 1 year ago

Hi @ant1dot , thank you for your PR!

Finally, it would be better if you write a simple test for the feature.

nikitakasatkin44 commented 1 year ago

Hello @JohnNiang In accordance with your request we have added tests for GenericEventItemListener. Please review an updated pull request. I look forward to your reply, have a good day.

ant1dot commented 1 year ago

Hello @JohnNiang can you accept pr, please?

ant1dot commented 1 year ago

@JohnNiang hello, can you release this is PR?

JohnNiang commented 1 year ago

@JohnNiang hello, can you release this is PR?

Sorry for the delay. Please refer to https://github.com/jenkinsci/generic-event-plugin/actions/runs/4786049588.