jenkinsci / generic-webhook-trigger-plugin

Can receive any HTTP request, extract any values from JSON or XML and trigger a job with those values available as variables. Works with GitHub, GitLab, Bitbucket, Jira and many more.
https://plugins.jenkins.io/generic-webhook-trigger
410 stars 162 forks source link

change filter to optional parameter in Job DSL #280

Closed limejuny closed 1 year ago

limejuny commented 1 year ago

Detail

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
limejuny commented 1 year ago

Hi, @tomasbjerre could you review my code?

and if you ok, could you label this PR hacktoberfest-accepted or set hacktoberfest on the repository topic? I am participating in hacktoberfest, and I will be happy if this PR is accepted as a hacktoberfest's contribution. (https://www.jenkins.io/events/hacktoberfest/#quick-start)