jenkinsci / generic-webhook-trigger-plugin

Can receive any HTTP request, extract any values from JSON or XML and trigger a job with those values available as variables. Works with GitHub, GitLab, Bitbucket, Jira and many more.
https://plugins.jenkins.io/generic-webhook-trigger
411 stars 162 forks source link

Enable triggering multibranch pipeline scan #89

Closed andreasgk16 closed 6 years ago

andreasgk16 commented 6 years ago

The plugin can't be used in Jenkins GUI when attempting to set the trigger for build jobs of type 'Multibranch Pipeline'.

Extend the GUI for

My Jenkins reference installation used when writing this issue:

tomasbjerre commented 6 years ago

Would be a nice feature.

I'm having trouble finding docs on how to do it for Multibranch Pipeline. The plugins that have this feature seems to just return true here: https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/master/src/main/java/org/jenkinsci/plugins/gwt/GenericTrigger.java#L44

Also this plugin did show up there in early versions. But was removed because it was not really supported: https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/6

andreasgk16 commented 6 years ago

Hi Tomas,

that’s a pity you removed it. It would be great to have the option in multibranch pipeline jobs again. The kind of jobs is very powerful and we usually use it for building of all changed branches of a project.

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 11:10 AM To: jenkinsci/generic-webhook-trigger-plugin generic-webhook-trigger-plugin@noreply.github.com Cc: Galek, Andreas Andreas.Galek@dieboldnixdorf.com; Author author@noreply.github.com Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

Would be a nice feature.

I'm having trouble finding docs on how to do it for Multibranch Pipeline. The plugins that have this feature seems to just return true here: https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/master/src/main/java/org/jenkinsci/plugins/gwt/GenericTrigger.java#L44

Also this plugin did show up there in early versions. But was removed because it was not really supported: #6https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/6

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439345720, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGesOA_kD1z-rAdH5dLoI1w2ca4Djpomks5uvo8EgaJpZM4Yl7nU.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

tomasbjerre commented 6 years ago

You just want to trigger a scan right? No need to extract variables? And filtering based on a regexp is just nice to have right?

Perhaps it is easier to extend the multibranch plugin with ability to trigger a scan from a URL invocation.

Den fre 16 nov. 2018 kl 11:16 skrev andreasgalek notifications@github.com:

Hi Tomas,

that’s a pity you removed it. It would be great to have the option in multibranch pipeline jobs again. The kind of jobs is very powerful and we usually use it for building of all changed branches of a project.

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 11:10 AM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.com> Cc: Galek, Andreas Andreas.Galek@dieboldnixdorf.com; Author < author@noreply.github.com> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

Would be a nice feature.

I'm having trouble finding docs on how to do it for Multibranch Pipeline. The plugins that have this feature seems to just return true here: https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/master/src/main/java/org/jenkinsci/plugins/gwt/GenericTrigger.java#L44

Also this plugin did show up there in early versions. But was removed because it was not really supported: #6< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/6>

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439345720>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AGesOA_kD1z-rAdH5dLoI1w2ca4Djpomks5uvo8EgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439347417, or mute the thread https://github.com/notifications/unsubscribe-auth/AAa1E-Mj5K8vjQ_CRlHa2SjOhkU7kFF0ks5uvpB5gaJpZM4Yl7nU .

andreasgk16 commented 6 years ago

Hi Tomas,

that’s right. Assuming I have a Git repository in Bitbucket with a webhook like: https://my-jenkins-server.com/generic-webhook-trigger/invoke/?token=test-token-2 that is called every time a commit is done to a branch in the repository.

Then, on the Jenkins side, the corresponding Multibranch Pipeline build job, with defined “Generic Webhook Trigger” / “Token = test-token-2”, should be executed which, in case of this kind of job, means executing the action “Scan Multibranch Pipeline Now”.

If your plugin would allow for it then it would be a perfect solution!

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 2:49 PM To: jenkinsci/generic-webhook-trigger-plugin generic-webhook-trigger-plugin@noreply.github.com Cc: Galek, Andreas Andreas.Galek@dieboldnixdorf.com; Author author@noreply.github.com Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

You just want to trigger a scan right? No need to extract variables? And filtering based on a regexp is just nice to have right?

Perhaps it is easier to extend the multibranch plugin with ability to trigger a scan from a URL invocation.

Den fre 16 nov. 2018 kl 11:16 skrev andreasgalek notifications@github.com<mailto:notifications@github.com>:

Hi Tomas,

that’s a pity you removed it. It would be great to have the option in multibranch pipeline jobs again. The kind of jobs is very powerful and we usually use it for building of all changed branches of a project.

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 11:10 AM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.commailto:generic-webhook-trigger-plugin@noreply.github.com> Cc: Galek, Andreas Andreas.Galek@dieboldnixdorf.com<mailto:Andreas.Galek@dieboldnixdorf.com>; Author < author@noreply.github.commailto:author@noreply.github.com> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

Would be a nice feature.

I'm having trouble finding docs on how to do it for Multibranch Pipeline. The plugins that have this feature seems to just return true here: https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/master/src/main/java/org/jenkinsci/plugins/gwt/GenericTrigger.java#L44

Also this plugin did show up there in early versions. But was removed because it was not really supported: #6< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/6>

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439345720>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AGesOA_kD1z-rAdH5dLoI1w2ca4Djpomks5uvo8EgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439347417, or mute the thread https://github.com/notifications/unsubscribe-auth/AAa1E-Mj5K8vjQ_CRlHa2SjOhkU7kFF0ks5uvpB5gaJpZM4Yl7nU .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439398188, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGesOFRIxeqhZURpGJJZ67bcJ45GtaBGks5uvsJfgaJpZM4Yl7nU.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

tomasbjerre commented 6 years ago

You should open an issue in that plugin to get such a feature implemented. I think they want a Jira created: https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Multibranch+Plugin

Den fre 16 nov. 2018 15:01 skrev andreasgalek notifications@github.com:

Hi Tomas,

that’s right. Assuming I have a Git repository in Bitbucket with a webhook like:

https://my-jenkins-server.com/generic-webhook-trigger/invoke/?token=test-token-2 that is called every time a commit is done to a branch in the repository.

Then, on the Jenkins side, the corresponding Multibranch Pipeline build job, with defined “Generic Webhook Trigger” / “Token = test-token-2”, should be executed which, in case of this kind of job, means executing the action “Scan Multibranch Pipeline Now”.

If your plugin would allow for it then it would be a perfect solution!

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 2:49 PM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.com> Cc: Galek, Andreas Andreas.Galek@dieboldnixdorf.com; Author < author@noreply.github.com> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

You just want to trigger a scan right? No need to extract variables? And filtering based on a regexp is just nice to have right?

Perhaps it is easier to extend the multibranch plugin with ability to trigger a scan from a URL invocation.

Den fre 16 nov. 2018 kl 11:16 skrev andreasgalek <notifications@github.com mailto:notifications@github.com>:

Hi Tomas,

that’s a pity you removed it. It would be great to have the option in multibranch pipeline jobs again. The kind of jobs is very powerful and we usually use it for building of all changed branches of a project.

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 11:10 AM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.com<mailto: generic-webhook-trigger-plugin@noreply.github.com>> Cc: Galek, Andreas <Andreas.Galek@dieboldnixdorf.com<mailto: Andreas.Galek@dieboldnixdorf.com>>; Author < author@noreply.github.commailto:author@noreply.github.com> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

Would be a nice feature.

I'm having trouble finding docs on how to do it for Multibranch Pipeline. The plugins that have this feature seems to just return true here:

https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/master/src/main/java/org/jenkinsci/plugins/gwt/GenericTrigger.java#L44

Also this plugin did show up there in early versions. But was removed because it was not really supported: #6< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/6>

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<

https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439345720>,

or mute the thread<

https://github.com/notifications/unsubscribe-auth/AGesOA_kD1z-rAdH5dLoI1w2ca4Djpomks5uvo8EgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439347417>,

or mute the thread < https://github.com/notifications/unsubscribe-auth/AAa1E-Mj5K8vjQ_CRlHa2SjOhkU7kFF0ks5uvpB5gaJpZM4Yl7nU>

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439398188>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AGesOFRIxeqhZURpGJJZ67bcJ45GtaBGks5uvsJfgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439401814, or mute the thread https://github.com/notifications/unsubscribe-auth/AAa1E5_O2k9LpihR_NwsqcKbaLP8-5jlks5uvsVSgaJpZM4Yl7nU .

tomasbjerre commented 6 years ago

To clearify. This plugin can trigger "jobs". The multibranch can create jobs and does so by scanning jenkinsfiles.

If you want to trigger the actual scanning, then that is a feature to implement in the Pipeline Multibranch Plugin.

If you want to trigger the jobs created by scanning, then you can use this plugin and configure it in the Jenkinsfile as described in the readme.

Den fre 16 nov. 2018 kl 15:19 skrev Tomas Bjerre tomas.bjerre85@gmail.com:

You should open an issue in that plugin to get such a feature implemented. I think they want a Jira created: https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Multibranch+Plugin

Den fre 16 nov. 2018 15:01 skrev andreasgalek notifications@github.com:

Hi Tomas,

that’s right. Assuming I have a Git repository in Bitbucket with a webhook like:

https://my-jenkins-server.com/generic-webhook-trigger/invoke/?token=test-token-2 that is called every time a commit is done to a branch in the repository.

Then, on the Jenkins side, the corresponding Multibranch Pipeline build job, with defined “Generic Webhook Trigger” / “Token = test-token-2”, should be executed which, in case of this kind of job, means executing the action “Scan Multibranch Pipeline Now”.

If your plugin would allow for it then it would be a perfect solution!

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 2:49 PM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.com> Cc: Galek, Andreas Andreas.Galek@dieboldnixdorf.com; Author < author@noreply.github.com> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

You just want to trigger a scan right? No need to extract variables? And filtering based on a regexp is just nice to have right?

Perhaps it is easier to extend the multibranch plugin with ability to trigger a scan from a URL invocation.

Den fre 16 nov. 2018 kl 11:16 skrev andreasgalek < notifications@github.commailto:notifications@github.com>:

Hi Tomas,

that’s a pity you removed it. It would be great to have the option in multibranch pipeline jobs again. The kind of jobs is very powerful and we usually use it for building of all changed branches of a project.

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 11:10 AM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.com<mailto: generic-webhook-trigger-plugin@noreply.github.com>> Cc: Galek, Andreas <Andreas.Galek@dieboldnixdorf.com<mailto: Andreas.Galek@dieboldnixdorf.com>>; Author < author@noreply.github.commailto:author@noreply.github.com> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

Would be a nice feature.

I'm having trouble finding docs on how to do it for Multibranch Pipeline. The plugins that have this feature seems to just return true here:

https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/master/src/main/java/org/jenkinsci/plugins/gwt/GenericTrigger.java#L44

Also this plugin did show up there in early versions. But was removed because it was not really supported: #6< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/6>

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<

https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439345720>,

or mute the thread<

https://github.com/notifications/unsubscribe-auth/AGesOA_kD1z-rAdH5dLoI1w2ca4Djpomks5uvo8EgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439347417>,

or mute the thread < https://github.com/notifications/unsubscribe-auth/AAa1E-Mj5K8vjQ_CRlHa2SjOhkU7kFF0ks5uvpB5gaJpZM4Yl7nU>

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439398188>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AGesOFRIxeqhZURpGJJZ67bcJ45GtaBGks5uvsJfgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439401814, or mute the thread https://github.com/notifications/unsubscribe-auth/AAa1E5_O2k9LpihR_NwsqcKbaLP8-5jlks5uvsVSgaJpZM4Yl7nU .

andreasgk16 commented 6 years ago

How can the Multibranch Pipeline Plugin know anything about “Generic Webhook Trigger”? Therefore I’m afraid the change can’t be done there. For my understanding the “Generic Webhook Trigger” Plugin should embed the corresponding option box into the configuration page of a Multibranch Pipeline build job, shouldn’t it?

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 3:33 PM To: jenkinsci/generic-webhook-trigger-plugin generic-webhook-trigger-plugin@noreply.github.com Cc: Galek, Andreas Andreas.Galek@dieboldnixdorf.com; Author author@noreply.github.com Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

To clearify. This plugin can trigger "jobs". The multibranch can create jobs and does so by scanning jenkinsfiles.

If you want to trigger the actual scanning, then that is a feature to implement in the Pipeline Multibranch Plugin.

If you want to trigger the jobs created by scanning, then you can use this plugin and configure it in the Jenkinsfile as described in the readme.

Den fre 16 nov. 2018 kl 15:19 skrev Tomas Bjerre tomas.bjerre85@gmail.com<mailto:tomas.bjerre85@gmail.com>:

You should open an issue in that plugin to get such a feature implemented. I think they want a Jira created: https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Multibranch+Plugin

Den fre 16 nov. 2018 15:01 skrev andreasgalek notifications@github.com<mailto:notifications@github.com>:

Hi Tomas,

that’s right. Assuming I have a Git repository in Bitbucket with a webhook like:

https://my-jenkins-server.com/generic-webhook-trigger/invoke/?token=test-token-2 that is called every time a commit is done to a branch in the repository.

Then, on the Jenkins side, the corresponding Multibranch Pipeline build job, with defined “Generic Webhook Trigger” / “Token = test-token-2”, should be executed which, in case of this kind of job, means executing the action “Scan Multibranch Pipeline Now”.

If your plugin would allow for it then it would be a perfect solution!

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 2:49 PM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.commailto:generic-webhook-trigger-plugin@noreply.github.com> Cc: Galek, Andreas Andreas.Galek@dieboldnixdorf.com<mailto:Andreas.Galek@dieboldnixdorf.com>; Author < author@noreply.github.commailto:author@noreply.github.com> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

You just want to trigger a scan right? No need to extract variables? And filtering based on a regexp is just nice to have right?

Perhaps it is easier to extend the multibranch plugin with ability to trigger a scan from a URL invocation.

Den fre 16 nov. 2018 kl 11:16 skrev andreasgalek < notifications@github.commailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>>:

Hi Tomas,

that’s a pity you removed it. It would be great to have the option in multibranch pipeline jobs again. The kind of jobs is very powerful and we usually use it for building of all changed branches of a project.

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 11:10 AM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.commailto<mailto:generic-webhook-trigger-plugin@noreply.github.com%3cmailto: generic-webhook-trigger-plugin@noreply.github.commailto:generic-webhook-trigger-plugin@noreply.github.com>> Cc: Galek, Andreas <Andreas.Galek@dieboldnixdorf.com<mailto: mailto:Andreas.Galek@dieboldnixdorf.com%3cmailto:%0b>> Andreas.Galek@dieboldnixdorf.commailto:Andreas.Galek@dieboldnixdorf.com>>; Author < author@noreply.github.commailto:author@noreply.github.com<mailto:author@noreply.github.com%3cmailto:author@noreply.github.com>> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

Would be a nice feature.

I'm having trouble finding docs on how to do it for Multibranch Pipeline. The plugins that have this feature seems to just return true here:

https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/master/src/main/java/org/jenkinsci/plugins/gwt/GenericTrigger.java#L44

Also this plugin did show up there in early versions. But was removed because it was not really supported: #6< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/6>

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<

https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439345720>,

or mute the thread<

https://github.com/notifications/unsubscribe-auth/AGesOA_kD1z-rAdH5dLoI1w2ca4Djpomks5uvo8EgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439347417>,

or mute the thread < https://github.com/notifications/unsubscribe-auth/AAa1E-Mj5K8vjQ_CRlHa2SjOhkU7kFF0ks5uvpB5gaJpZM4Yl7nU>

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439398188>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AGesOFRIxeqhZURpGJJZ67bcJ45GtaBGks5uvsJfgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439401814, or mute the thread https://github.com/notifications/unsubscribe-auth/AAa1E5_O2k9LpihR_NwsqcKbaLP8-5jlks5uvsVSgaJpZM4Yl7nU .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439411143, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGesOJIk47kV3qL5OzZppPYp4C2YtH1oks5uvsylgaJpZM4Yl7nU.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

tomasbjerre commented 6 years ago

They dont need anything from this plugin in order to implement that feature.

Den fre 16 nov. 2018 15:37 skrev andreasgalek notifications@github.com:

How can the Multibranch Pipeline Plugin know anything about “Generic Webhook Trigger”? Therefore I’m afraid the change can’t be done there. For my understanding the “Generic Webhook Trigger” Plugin should embed the corresponding option box into the configuration page of a Multibranch Pipeline build job, shouldn’t it?

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 3:33 PM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.com> Cc: Galek, Andreas Andreas.Galek@dieboldnixdorf.com; Author < author@noreply.github.com> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

To clearify. This plugin can trigger "jobs". The multibranch can create jobs and does so by scanning jenkinsfiles.

If you want to trigger the actual scanning, then that is a feature to implement in the Pipeline Multibranch Plugin.

If you want to trigger the jobs created by scanning, then you can use this plugin and configure it in the Jenkinsfile as described in the readme.

Den fre 16 nov. 2018 kl 15:19 skrev Tomas Bjerre <tomas.bjerre85@gmail.com mailto:tomas.bjerre85@gmail.com>:

You should open an issue in that plugin to get such a feature implemented. I think they want a Jira created: https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Multibranch+Plugin

Den fre 16 nov. 2018 15:01 skrev andreasgalek <notifications@github.com mailto:notifications@github.com>:

Hi Tomas,

that’s right. Assuming I have a Git repository in Bitbucket with a webhook like:

https://my-jenkins-server.com/generic-webhook-trigger/invoke/?token=test-token-2 that is called every time a commit is done to a branch in the repository.

Then, on the Jenkins side, the corresponding Multibranch Pipeline build job, with defined “Generic Webhook Trigger” / “Token = test-token-2”, should be executed which, in case of this kind of job, means executing the action “Scan Multibranch Pipeline Now”.

If your plugin would allow for it then it would be a perfect solution!

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 2:49 PM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.com<mailto: generic-webhook-trigger-plugin@noreply.github.com>> Cc: Galek, Andreas <Andreas.Galek@dieboldnixdorf.com<mailto: Andreas.Galek@dieboldnixdorf.com>>; Author < author@noreply.github.commailto:author@noreply.github.com> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

You just want to trigger a scan right? No need to extract variables? And filtering based on a regexp is just nice to have right?

Perhaps it is easier to extend the multibranch plugin with ability to trigger a scan from a URL invocation.

Den fre 16 nov. 2018 kl 11:16 skrev andreasgalek < notifications@github.com<mailto:notifications@github.com<mailto: notifications@github.com%3cmailto:notifications@github.com>>>:

Hi Tomas,

that’s a pity you removed it. It would be great to have the option in multibranch pipeline jobs again. The kind of jobs is very powerful and we usually use it for building of all changed branches of a project.

Thanks and Regards, Andreas Galek

From: Tomas Bjerre [mailto:notifications@github.com] Sent: Friday, November 16, 2018 11:10 AM To: jenkinsci/generic-webhook-trigger-plugin < generic-webhook-trigger-plugin@noreply.github.com<mailto<mailto: generic-webhook-trigger-plugin@noreply.github.com%3cmailto>: generic-webhook-trigger-plugin@noreply.github.com<mailto: generic-webhook-trigger-plugin@noreply.github.com>>> Cc: Galek, Andreas <Andreas.Galek@dieboldnixdorf.com<mailto: mailto:Andreas.Galek@dieboldnixdorf.com%3cmailto:%0b>> Andreas.Galek@dieboldnixdorf.commailto:Andreas.Galek@dieboldnixdorf.com>>; Author < author@noreply.github.com<mailto:author@noreply.github.com<mailto: author@noreply.github.com%3cmailto:author@noreply.github.com>>> Subject: Re: [jenkinsci/generic-webhook-trigger-plugin] Implement support for multibranch pipeline build jobs (#89)

Would be a nice feature.

I'm having trouble finding docs on how to do it for Multibranch Pipeline. The plugins that have this feature seems to just return true here:

https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/master/src/main/java/org/jenkinsci/plugins/gwt/GenericTrigger.java#L44

Also this plugin did show up there in early versions. But was removed because it was not really supported: #6< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/6>

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<

https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439345720>,

or mute the thread<

https://github.com/notifications/unsubscribe-auth/AGesOA_kD1z-rAdH5dLoI1w2ca4Djpomks5uvo8EgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439347417>,

or mute the thread <

https://github.com/notifications/unsubscribe-auth/AAa1E-Mj5K8vjQ_CRlHa2SjOhkU7kFF0ks5uvpB5gaJpZM4Yl7nU>

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<

https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439398188>,

or mute the thread<

https://github.com/notifications/unsubscribe-auth/AGesOFRIxeqhZURpGJJZ67bcJ45GtaBGks5uvsJfgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439401814>,

or mute the thread < https://github.com/notifications/unsubscribe-auth/AAa1E5_O2k9LpihR_NwsqcKbaLP8-5jlks5uvsVSgaJpZM4Yl7nU>

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439411143>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AGesOJIk47kV3qL5OzZppPYp4C2YtH1oks5uvsylgaJpZM4Yl7nU>.

WINCOR NIXDORF International GmbH Sitz der Gesellschaft: Paderborn Registergericht Paderborn HRB 3507 Geschäftsführer: Dr. Ulrich Näher (Vorsitzender), Christopher A. Chapman, Olaf Heyden Vorsitzender des Aufsichtsrats: Dr. Alexander Dibelius Steuernummer: 339/5884/0530 - Ust-ID Nr.: DE812927716 - WEEE-Reg.-Nr. DE44477193

Diese E-Mail enthält vertrauliche Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet.

This e-mail may contain confidential information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/89#issuecomment-439412532, or mute the thread https://github.com/notifications/unsubscribe-auth/AAa1E_WdB48Zm8sT5i4zN2AbYurdFTPxks5uvs24gaJpZM4Yl7nU .

igalg commented 5 years ago

I had the same problem. decided to solve this issue https://github.com/jenkinsci/multibranch-scan-webhook-trigger-plugin

AmarettoSlim commented 5 years ago

I had the same problem. decided to solve this issue https://github.com/jenkinsci/multibranch-scan-webhook-trigger-plugin

@igalg Any chance you can add functionality to run a "Build Now" when a pr:open or pr:merged web hook payload comes in for a branch?

Right now the multi-branch scan will invoke when the payload is sent, but it quickly sees there are no changes to the branch (since you push to origin, which initiates a scan, and then open a pr, which initiates a scan but the commit hasn't changed since the previous push so nothing is built).

Asking here because I can't seem to open an issue on the repo itself.

Thanks!

igalg commented 5 years ago

Hi. It’s look like what you are trying to do supported with generic Webhook plugin. You can create a Webhook for pr:open and pr:merged events.

In the multibranch pipeline you should select suppress scm triggering

Look in the generic Webhook plugin documentation how to configure multibranch pipeline.

Let me know if it’s solve your problem.

Sent from my iPhone

On 9 Jul 2019, at 20:52, AmarettoSlim notifications@github.com wrote:

I had the same problem. decided to solve this issue https://github.com/jenkinsci/multibranch-scan-webhook-trigger-plugin

@igalg Any chance you can add functionality to run a "Build Now" when a pr:open or pr:merged web hook payload comes in for a branch?

Right now the multi-branch scan will invoke when the payload is sent, but it quickly sees there are no changes to the branch (since you push to origin, which initiates a scan, and then open a pr, which initiates a scan but the commit hasn't changed since the previous push so nothing is built).

Asking here because I can't seem to open an issue on the repo itself.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.