search

jenkinsci / ghprb-plugin

github pull requests builder plugin for Jenkins
https://plugins.jenkins.io/ghprb/
MIT License
506 stars 612 forks source link

Allow build to be triggered on PR title update if previous title matched skipBuildPhrase #740

Open andrew-garland opened 5 years ago

andrew-garland commented 5 years ago

The comment in https://github.com/jenkinsci/ghprb-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java#L324 is quite clear that the current behavior is by design but it defeats a workflow that we have.

We use WIP plugin to prevent merging PRs that are still under development. At such time as the PR is ready, the submitter will remove WIP from the PR title. This workflow allows other team members to provide review comments earlier in the development process.

We could build such PRs constantly, but this would just clog up our jenkins doing premature testing, so we added WIP to the skipBuildPhrase.

The ideal workflow for us is for GHPRB to kick in at the time WIP is removed from the PR title.

andrew-garland commented 5 years ago

On a side note, I know there is a workaround to have users kick off a build by adding a comment. However, this just adds an opportunity for someone to forget to do it, where as the PR title has to be updated or else the PR cannot be merged.

Also, I personally don't understand the rationale for building on comments, so would prefer not to receive webhooks about Issue Comments. Why would I want to build/test a PR N times just because N comments were added?