search

jenkinsci / ghprb-plugin

github pull requests builder plugin for Jenkins
https://plugins.jenkins.io/ghprb/
MIT License
506 stars 611 forks source link

Possible regression in jenkinsci GitHub API 1.109 update breaking jenkinsci GHPRB plugin #773

Closed Panajev closed 4 years ago

Panajev commented 4 years ago

Describe the bug After updating GitHub API Plugin to 1.109 the post receive hooks would not cause a GitHub Pull Request Builder based job to execute. Reverting to 1.106, restarting Jenkins, and ensuring the commit hook fired again would start the job once more

Issue also raised in the jenkinsci GitHub API project: https://github.com/github-api/github-api/issues/776

To Reproduce Steps to reproduce the behavior:

  1. Update GitHub API Plugin from 1.106 to 1.109
  2. Create new PR for a repository with a post receive commit hook setup (there is a matching Jenkins job configured with the jenkinsci GitHub Pull Request Builder plugin) so that the hook fires (or you can use a PR comment to do the same if configured in your GHPRB setup)

Expected behavior Jenkins job is started

Actual behavior Jenkins job is not started. Reverting GitHub Api Plugin to 1.106 fixes the issue

Desktop (please complete the following information):

Panajev commented 4 years ago

Should be fixed by https://github.com/jenkinsci/ghprb-plugin/pull/772

samrocketman commented 4 years ago

Thanks for closing. Yeah, it should be.