jenkinsci / ghprb-plugin

github pull requests builder plugin for Jenkins
https://plugins.jenkins.io/ghprb/
MIT License
501 stars 608 forks source link

Unable to save settings of GHPRB #814

Open PavelCZE opened 3 years ago

PavelCZE commented 3 years ago

Version report

Jenkins and plugins versions report:

Jenkins: 2.277.1
ghprb:1.42.2

Reproduction steps

Results

Expected result:

Project is saved

Actual result:

Project saving fails with error message: JSONObject["org-jenkinsci-plugins-ghprb-GhprbTrigger"] is not a JSONObject.

Log shows the following incorrect JSON structure

"org-jenkinsci-plugins-ghprb-GhprbTrigger":true,"gitHubAuthId":"abc-abc-abc-abc-abc","adminlist":"","useGitHubHooks":false,"triggerPhrase":"","onlyTriggerPhrase":false,"autoCloseFailedPullRequests":false,"skipBuildPhrase":".*\\[skip\\W+ci\\].*","displayBuildErrorsOnDownstreamBuilds":false,"cron":["H/5 * * * *","H/5 * * * *",""],"whitelist":"","orgslist":"","blackListLabels":"","whiteListLabels":"","allowMembersOfWhitelistedOrgsAsAdmin":false,"permitAll":false,"buildDescTemplate":"","blackListCommitAuthor":"","whiteListTargetBranches":{"branch":""},"blackListTargetBranches":{"branch":""},"includedRegions":"","excludedRegions":"",