jenkinsci / ghprb-plugin

github pull requests builder plugin for Jenkins
https://plugins.jenkins.io/ghprb/
MIT License
507 stars 612 forks source link

remove the caching and use GithubAppCredentials from github source br… #820

Closed ataylor-r7 closed 3 years ago

ataylor-r7 commented 3 years ago

Presently on "mvn install" it fails with spotbugs plugin ... but on "mvn package" it packages just fine.

It was failing a test before, but right now it doesn't seem to be failing on "mvn package" so I'll leave it unless those failing tests show up again and I need to revisit.

This prevents caching Github connections & credentials, which allows it to constantly pull the most updated credential ID & credentials associated with that ID.

This also now allows use of GithubAppCredentials from the github source branch plugin