check if commit author is blacklisted before checking if they are whitelisted

jenkinsci / ghprb-plugin

github pull requests builder plugin for Jenkins

https://plugins.jenkins.io/ghprb/

MIT License

498 stars 606 forks source link

check if commit author is blacklisted before checking if they are whitelisted #830

Open maorfr opened 2 years ago

maorfr commented 2 years ago

this PR is an implementation proposal to prevent cases like #831 by adding known users to the list of committers to skip (introduced in #488). if the PR author is in the deny list, they will never be checked for org membership.

this will prevent the api call that returns 404 and will prevent rate limit.

internal reference: https://issues.redhat.com/browse/APPSRE-4423

maorfr commented 2 years ago

@jenkinsci/ghprb-plugin-developers any chance you can take a look? hope the approach makes sense!