jenkinsci / ghprb-plugin

github pull requests builder plugin for Jenkins
https://plugins.jenkins.io/ghprb/
MIT License
506 stars 612 forks source link

Create new pull request with a comments,but not be triggered. Comment a gain and reopen the pull request,then be triggered #836

Closed fnhchaiyin closed 2 years ago

fnhchaiyin commented 2 years ago

Jenkins and plugins versions report

Environment ```Result Jenkins: 2.332.3 OS: Linux - 5.4.0-104-generic --- ace-editor:1.1 ant:475.vf34069fef73c antisamy-markup-formatter:2.7 apache-httpcomponents-client-4-api:4.5.13-1.0 bootstrap5-api:5.1.3-6 bouncycastle-api:2.26 branch-api:2.1046.v0ca_37783ecc5 build-timeout:1.20 caffeine-api:2.9.3-65.v6a_47d0f4d1fe checks-api:1.7.3 cloudbees-folder:6.714.v79e858ef76a_2 command-launcher:81.v9c2cb_cb_db_392 credentials:1087.1089.v2f1b_9a_b_040e4 credentials-binding:523.vd859a_4b_122e6 display-url-api:2.3.6 durable-task:496.va67c6f9eefa7 echarts-api:5.3.2-1 email-ext:2.88 font-awesome-api:6.0.0-1 ghprb:1.42.2 git:4.11.1 git-client:3.11.0 git-server:1.10 github:1.34.3 github-api:1.303-400.v35c2d8258028 github-branch-source:1599.v9fb_798a_a_7c4f gradle:1.38 handlebars:3.0.8 jackson2-api:2.13.2.20220328-273.v11d70a_b_a_1a_52 javax-activation-api:1.2.0-3 javax-mail-api:1.6.2-6 jaxb:2.3.0.1 jdk-tool:1.5 jjwt-api:0.11.2-71.v2722b_b_06a_2a_f jquery3-api:3.6.0-3 jsch:0.1.55.2 junit:1.63 ldap:2.9 lockable-resources:2.14 mailer:414.vcc4c33714601 matrix-auth:3.1.2 matrix-project:771.v574584b_39e60 momentjs:1.1.1 okhttp-api:4.9.3-105.vb96869f8ac3a pam-auth:1.8 pipeline-build-step:2.18 pipeline-github-lib:36.v4c01db_ca_ed16 pipeline-graph-analysis:195.v5812d95a_a_2f9 pipeline-input-step:448.v37cea_9a_10a_70 pipeline-milestone-step:101.vd572fef9d926 pipeline-model-api:2.2077.vc78ec45162f1 pipeline-model-definition:2.2077.vc78ec45162f1 pipeline-model-extensions:2.2077.vc78ec45162f1 pipeline-rest-api:2.24 pipeline-stage-step:293.v200037eefcd5 pipeline-stage-tags-metadata:2.2077.vc78ec45162f1 pipeline-stage-view:2.24 plain-credentials:1.8 plugin-util-api:2.16.0 popper2-api:2.11.5-1 resource-disposer:0.19 scm-api:608.vfa_f971c5a_a_e9 script-security:1158.v7c1b_73a_69a_08 snakeyaml-api:1.30.1 ssh-credentials:277.v95c2fec1c047 ssh-slaves:1.814.vc82988f54b_10 sshd:3.228.v4c9f9e652c86 structs:318.va_f3ccb_729b_71 timestamper:1.17 token-macro:293.v283932a_0a_b_49 trilead-api:1.57.v6e90e07157e1 variant:1.4 workflow-aggregator:2.7 workflow-api:1144.v61c3180fa_03f workflow-basic-steps:948.v2c72a_091b_b_68 workflow-cps:2689.v434009a_31b_f1 workflow-cps-global-lib:570.v21311f4951f8 workflow-durable-task-step:1130.v8fd69d0b_8857 workflow-job:1180.v04c4e75dce43 workflow-multibranch:712.vc169a_1387405 workflow-scm-step:399.v9b_8f4da_65061 workflow-step-api:625.vd896b_f445a_f8 workflow-support:819.v37d707a_71d9b_ ws-cleanup:0.42 ```

What Operating System are you using (both controller, and any agents involved in the problem)?

OS: Ubuntu 18.04.6 LTS GitHub Enterprise Server 3.3.7 I create a new 'pull request' with a comments,but not triggered. Jenkins log: _May 06, 2022 9:27:32 AM INFO org.jenkinsci.plugins.ghprb.GhprbTrigger$StartHookRunnable run Created hook for xxxx/xxxx May 06, 2022 9:27:34 AM INFO org.jenkinsci.plugins.ghprb.GhprbTrigger$StartHookRunnable run Created hook for xxxx/xxxx May 06, 2022 9:27:35 AM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction handleAction Checking PR #4 for xxxx/xxxx May 06, 2022 9:27:35 AM INFO org.jenkinsci.plugins.ghprb.GhprbTrigger handlePR Checking PR #4 for job XMI_MCORE_pr_pipeline_bootloaders32g May 06, 2022 9:27:36 AM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest Created Pull Request #4 on xxxx/xxxx by uif04764 () updated at: 5/6/22, 9:27 AM SHA: 46f0f06fc6f92d03802e670fdb243b0696814fd1 May 06, 2022 9:27:36 AM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest updatePR Pull request #4 was updated on repo xxxx/xxxx but there aren't any new comments nor commits; that may mean that commit status was updated.

Reproduction steps

  1. Create a new 'pull request' with comments in my github, not be triggered.
  2. Close the 'pull request' and reopen without comments,not be triggered.
  3. Close the 'pull request' and reopen with a comments, be triggered.

Expected Results

I checked the option "Only use trigger phrase for build triggering", still not be triggered when I create a new 'pull request'

Actual Results

A new 'pull request' with comments will be trigger

Anything else?

No response