Open cdoughty-r7 opened 2 years ago
What needs to happen for this to be merged? Seeing as GitHub started enforcing MFA for all users, their guideline for bots is to be a GitHub app, and adding this support became critical, at least for us. I'm not familiar with Java development, if someone can help onboard me into the process, I'll be happy to help with the plugin maintenance.
Tldr; This allows GHPRB to constantly pull updated credentials and also gives the option to use GithubAppCredentials from github source branch which handles rotating the app installation token every hour.
Why:
Other interest we found: https://github.com/jenkinsci/ghprb-plugin/pull/812 https://github.com/jenkinsci/ghprb-plugin/pull/813
How:
Benefits:
** Right now on "mvn install" this fails with spotbugs plugin but packages fine with "mvn package" Failure starts with:
It was also failing on 2 unit tests originally bc my changes broke what the test was expecting but can't replicate that presently, so I'll leave the tests as long as those don't show up again.