jenkinsci / ghprb-plugin

github pull requests builder plugin for Jenkins
https://plugins.jenkins.io/ghprb/
MIT License
507 stars 612 forks source link

Prevent triggering builds on closed PRs #866

Open JackPGreen opened 2 months ago

JackPGreen commented 2 months ago

Skips all kind of event triggers for closed PRs, rather than just for comments as per https://github.com/jenkinsci/ghprb-plugin/pull/54.

Fixes: https://github.com/jenkinsci/ghprb-plugin/issues/865

Testing done

I've not added a test to cover this, as there's no existing test coverage for pull_request events in org.jenkinsci.plugins.ghprb.GhprbRootActionTest, nor is there any example payloads in org.jenkinsci.plugins.ghprb.GhprbTestUtil. I've tested on a private Jenkins instance.

Submitter checklist