search

jenkinsci / github-autostatus-plugin

Jenkins plugin to provide automatic status for multibranch jobs
https://plugins.jenkins.io/github-autostatus/
MIT License
52 stars 34 forks source link

"Error Signal" appears on pull requests when influxdb is not configured #68

Open sgleske-ias opened 4 years ago

sgleske-ias commented 4 years ago

Bug report

A failed pull request occasionally get's an Error Signal context voted back in the pull request. The following is a screenshot example,

Screen Shot 2019-10-18 at 4 27 26 PM

When the pull request is updated and fixed the Error Signal does not go away because there's no valid stage which votes back "success" for this status. It is confusing to end users who are using GitHub for pull requests and Jenkins for verifying pull requests.

Desired behavior

Error Signal does not get reported to GitHub pull requests.

Related closed issues

Since this is a new issue on a newer version I decided to open a new GitHub issue. This was earlier reported and fixed in #31 (Subject: Jenkins reports "Error signal" context on failure)

Additional Information

Using:

jeffpearce commented 4 years ago

Oops! It was fixed, but I subsequently refactored the code to simplify and regressed it.

sgleske-ias commented 4 years ago

No worries, thank you for your maintenance and support! This plugin is very valuable so users and admins don't have to futz around with trying to vote back statuses to pull requests.

darxriggs commented 4 years ago

@jeffpearce can this be closed now? You fixed it in #70 - right?

jeffpearce commented 4 years ago

@sgleske-ias - can you verify it's fixed?