search

jenkinsci / github-issues-plugin

Jenkins plugin to create GitHub issues for failing builds
https://plugins.jenkins.io/github-issues
MIT License
5 stars 6 forks source link

Add workflow support #8

Closed BenjaminGill-Metaswitch closed 7 years ago

BenjaminGill-Metaswitch commented 7 years ago

This seems to compile, but I haven't managed to actually test this properly...

Should resolve JENKINS-42629

~- [ ] Work out whether testable~ ~- [ ] Write up necessary configuration in pipelines (declarative and legacy)~

Daniel15 commented 7 years ago

Thanks for the pull request. I'd like to get confirmation that it actually works before merging the pull request 😃

Some unit tests would be nice but I know very little about Java and am not sure how to write unit tests for Jenkins plugins :(

BenjaminGill-Metaswitch commented 7 years ago

OK. I've now installed the new package on a production system, and it appears to work (i.e. it can now raise issues within a pipeline where before it couldn't).

I don't really understand the UT framework here, but will have a go at seeing if I can test this...

BenjaminGill-Metaswitch commented 7 years ago

Right. I've been using this for the past 10 days in production without significant problems. I've still not worked out how the UTs work for this plugin, though.

I think the correct place for documentation will be https://wiki.jenkins-ci.org/display/JENKINS/GitHub+Issues+Plugin, once a release appears with this feature:

As an example (note that the GitHub project must be configured in the main Jenkins config):

script {
    properties([[$class: 'GithubProjectProperty',
                projectUrlStr: '<GitHub repo URL>']])
}

...

step([$class: 'GitHubIssueNotifier',
      issueAppend: true,
      issueLabel: '',
      issueTitle: '$JOB_NAME $BUILD_DISPLAY_NAME failed'])

Is this worth merging now?

BenjaminGill-Metaswitch commented 7 years ago

Is this able to be merged?

Daniel15 commented 7 years ago

Sorry, I'll take a look soon. Thanks for your contribution!

Sent from my phone.

On Jul 7, 2017 5:20 AM, "Benjamin Gill" notifications@github.com wrote:

Is this able to be merged?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/github-issues-plugin/pull/8#issuecomment-313666296, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFnHQVI57AGNx6i5_jvOPiG2uBrmdehks5sLiJ-gaJpZM4Nugxs .

Daniel15 commented 7 years ago

Published as v1.2.3. Thanks for your contribution!