jenkinsci / gitlab-plugin

A Jenkins plugin for interfacing with GitLab
https://plugins.jenkins.io/gitlab-plugin/
GNU General Public License v2.0
1.43k stars 613 forks source link

[GSoC Milestone 1] Migrate resource calls from RESTEasy to GitLab4J-API #1501

Closed harsh-ps-2003 closed 1 year ago

harsh-ps-2003 commented 1 year ago

This PR migrates the GitLab Plugin's resource calls from RESTEasy to GitLab4J-API without affecting the older Webhook implementation. The Proxy Configuration is currently non-functional.

An attempt has been made to adapt Docker Based Functional Tests accordingly.

krisstern commented 1 year ago

@basil I have re-enabled the tests and everything seems to be in working order for this PR

krisstern commented 1 year ago

Review Checklist

To be signed off by @krisstern.

krisstern commented 1 year ago

@harsh-ps-2003 I have made some requests for changes. I will need to test interactively once again after these changes have been made, and can merge the PR after that.

krisstern commented 1 year ago

Thanks for your hard work @harsh-ps-2003! I tried it interactively with a push event and it worked. For testing for merge request I am seeing the below:

Screenshot 2023-07-30 at 4 27 17 PM

Which may mean that I need a bit working on my own setup.

So to follow up, once I have set up a proper merge request for the merge test the test was passed:

Screenshot 2023-07-30 at 5 55 19 PM