Open Nataliia-Kyr opened 9 months ago
Hey maintainers, I was trying to solve this issue and wanted to ask you some questions about it.
To solve this issue do we have to make changes in the core plugin like below?
Draft code to check whether the merge request is successful or not.
or we should simply make the changes in the pipeline script
README.md modification like the below
Can anyone please help me with this?
Jenkins and plugins versions report
Environment
```text Paste the output here ```What Operating System are you using (both controller, and any agents involved in the problem)?
Gitlab plugin version: 1.5.33 Gitlab version: 15.11.13 Jenkins version: 2.401.1 (running as a Docker container on Red Hat Enterprise Linux v8.8 Ootpa) Job type: Pipeline
Reproduction steps
acceptGitLabMR = acceptGitLabMR(useMRDescription: true, removeSourceBranch: true)
Expected Results
acceptGitlabMR throws Exception if for some reason merging MR has failed. For example, if MR needs a rebase and GitLab configured to not allow auto-merging such MRs
Actual Results
acceptGitlabMR always returns "Success" even if MR is not actually merged. Currently it`s not possible to validate if MR was successfully merged or not
Anything else?
Result of command acceptGitlabMR() needs to be handled and validated. For example, to be able to use it in try-catch section.