jenkinsci / gitlab-plugin

A Jenkins plugin for interfacing with GitLab
https://plugins.jenkins.io/gitlab-plugin/
GNU General Public License v2.0
1.44k stars 612 forks source link

Fix "Test Connection" button when used with Jackson 2.16.1 or later #1606

Closed bruderol closed 8 months ago

bruderol commented 8 months ago

Here is a pull request for the proposed solution as proposed and discussed on the issue #1605 - would be great if you could release that soon please.

Testing done?

When the most recent Jackson 2 API plugin (2.16.1.x) is used, compilation fails without this change and succeeds with this change. Interactive testing of the "Test connection" button confirms that the new code is well behaved

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x]  Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests
MarkEWaite commented 8 months ago

@krisstern and @harsh-ps-2003 I think that we should merge the pull requests and deliver the 1.8.0 release of the GitLab plugin. The pull requests are:

Does that seem reasonable for the two of you?

krisstern commented 8 months ago

@krisstern and @harsh-ps-2003 I think that we should merge the pull requests and deliver the 1.8.0 release of the GitLab plugin. The pull requests are:

Does that seem reasonable for the two of you?

Sure, this makes sense to me

MarkEWaite commented 8 months ago

Sure, this makes sense to me

Thanks. I'll plan to generate a release in a few hours.

bruderol commented 7 months ago

@MarkEWaite wow, I am impresed - thank you for testing and releasing it so fast. That was a great experience :-) Will immediately test the new release. Thanks so much.

And I can allready confirm, that the new release does not have that issue anymore. Thank you!