Revert "Replaced Arguements With Empty Array"

jenkinsci / gitlab-plugin

A Jenkins plugin for interfacing with GitLab

https://plugins.jenkins.io/gitlab-plugin/

GNU General Public License v2.0

1.44k stars 613 forks source link

Revert "Replaced Arguements With Empty Array" #1622

Closed krisstern closed 8 months ago

krisstern commented 8 months ago

Reverts jenkinsci/gitlab-plugin#1614

AniketNS commented 8 months ago

Hey @krisstern, Can I ask you why did you revert this commit?

krisstern commented 8 months ago

Hi @AniketNS, as I have explained in https://github.com/jenkinsci/gitlab-plugin/pull/1614#issuecomment-1894096472, a Java Array is always of fixed size and not of dynamic size. If you fixed its length to be 0 then its sole purpose will be to serve as a zero-length array, which in most cases serve as a placeholder. In our context we want the Arrays to be of a certain length to begin with, hence the revert of the PR.

AniketNS commented 8 months ago

Ohh ok. Thanks for the detailed explanation @krisstern

krisstern commented 8 months ago

No problem