jenkinsci / gitlab-plugin

A Jenkins plugin for interfacing with GitLab
https://plugins.jenkins.io/gitlab-plugin/
GNU General Public License v2.0
1.44k stars 613 forks source link

update PushBuildAction to use 'AbstractGitSCMSource' to trigger 'GitLab Branch Source' repository scan #1629

Closed nicomodeus closed 8 months ago

nicomodeus commented 8 months ago

The 'PushBuildAction' does not trigger updates for projects created with 'GitLab Branch Source' plugin.

In the Jenkins logs you could only find a trace of the webhook POST sent by the GitLab Jenkins integration, but no further trace of anything and no build was scheduled.

This is because the actual SCMSource implementation in 'GitLab Branch Source' does not inherit from 'GITScmSource'.

Using 'AbstractGitSCMSource' instead of 'GitSCMSource' fixes that.

Testing done

krisstern commented 8 months ago

Thanks @nicomodeus!