[JENKINS-73135] Require Jenkins 2.472, adapt tests for Jetty 12 EE 8 - Githubissues

jenkinsci / gitlab-plugin

A Jenkins plugin for interfacing with GitLab

https://plugins.jenkins.io/gitlab-plugin/

GNU General Public License v2.0

1.44k stars 619 forks source link

[JENKINS-73135] Require Jenkins 2.472, adapt tests for Jetty 12 EE 8 #1678

Closed ampuscas closed 3 months ago

ampuscas commented 3 months ago

JENKINS-73135 - Require Jenkins 2.472 or newer, adapt tests for Jetty 12 EE 8

Testing done

Automated tests pass on Linux with Java 21.

Submitter checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

MarkEWaite commented 3 months ago

Thanks for the pull request @ampuscas . I pushed two changes to the pull request so that it compiles and passes tests on my local installation. The comments in the changes should explain why I thought they would help. Refer to:

e7a0b0887c6957b0573b441e94e175a61b5d37a4 - Use newer Jenkins LTS baseline for BOM
c169b4fc4b8b7d0d6e8244f47fab015319fafcd1 - Format with spotless

MarkEWaite commented 3 months ago

@krisstern I think that we should increment the minor number from 1.8.x to 1.9.0 when merging this pull request, because it changes the minimum Jenkins version and it switches from Java 11 compilation to Java 17 compilation. Does that match with your thinking or would you prefer something different?

We need to merge and release this before the plugin bill of materials release at the end of this week.

MarkEWaite commented 3 months ago

Code looks good to me, but I do not have an idea what is that jenkins.baseline property

It is used in the Jenkins plugin archetype and in many plugins to avoid duplicating the Jenkins version string in multiple locations. More information is available in:

MarkEWaite commented 3 months ago

Thanks for merging @krisstern ! Are you able to release this as a new version so that it can be updated in the plugin BOM or would you prefer that I create the release?

Should the version number of the new release be 1.9.0 rather than the default of 1.8.3 because the Jenkins minimum version is increased?

krisstern commented 3 months ago

Hi @MarkEWaite I am busy with something else now so if you are able to could you please create a new release? Thanks!

MarkEWaite commented 3 months ago

Release 1.9.0 is building now.

MarkEWaite commented 3 months ago

Release 1.9.0 is published.