Closed azerbe closed 6 years ago
azerbe
commented
6 years ago Sidenote: If I remove the parameters from the jenkinsjob (not the EnvPlugin) and keep it parameterized, the build also works.
So at some place the submitted environment variables are getting replaced by the empty ones, defined in the jenkins-job.
omehegan
commented
6 years ago @azerbe can you share the envinject code you are using to set the variables? Also, in your "sidenote" comment, I don't understand what you mean when you say you remove the parameters and keep it parameterized.
azerbe
commented
6 years ago Hello @omehegan ,
thanks for the response.
Following the Env-Variables:
import hudson.model.*
def env = Thread.currentThread()?.executable.parent.builds[0].properties.get('envVars')
def map = [:]
if (env['gitlabSourceBranch'] != null) {
map['gitlabSourceBranch'] = env['gitlabSourceBranch']
}
if (env['gitlabTargetBranch'] != null) {
map['gitlabTargetBranch'] = env['gitlabTargetBranch']
}
// Add additional entries for any other parameters you have created
return mapForget my comment about the parameterized configuration. I just left the checkmark for This build is parameterized, but Jenkins removes that if you don't have any parameters configured.
The base problem still remains. If I add two text parameters named gitlabSouceBranch and gitlabTargetBranch to the jenkins build, they overwrite the values provided by the gitlab-plugin with an empty string.
Do I have to add some default Values?
omehegan
commented
6 years ago I got the envinject code for this from @ElijahLynn in another issue, and added it to the README. Maybe he can help you out with this. Please let me know if it turns out I need to change something in the doc.
azerbe
commented
6 years ago I don't think this code is wrong. I use it without the parameters set and it works. But I would like to be able to start a build by hand from time to time. And I don't know how to debug the plugin to see, when the values are being overwritten.
omehegan
commented
6 years ago The whole point of that code was to allow you to do exactly what you are trying to do, so if it's not working we'll have to figure it out :) See https://github.com/jenkinsci/gitlab-plugin/issues/356#issuecomment-385594555
azerbe
commented
6 years ago The question is, if i named the parameters wrong. @ElijahLynn called them sourceBranch instead of gitlabSourceBranch in his comment. I can check that later.
Just for clarification:
ElijahLynn
commented
6 years ago K, it looks like the documentation commit wasn't precisely what my code was/is, here is what is working right now for my team:
import hudson.model.*
def env = Thread.currentThread()?.executable.parent.builds[0].properties.get('envVars')
def map = [:]
if (env['gitlabSourceBranch'] != null) {
map['SourceBranch'] = env['gitlabSourceBranch']
}
if (env['gitlabTargetBranch'] != null) {
map['TargetBranch'] = env['gitlabTargetBranch']
}
return map
ElijahLynn
commented
6 years ago I created the PR above, the only thing that differs from it and the comment above is that it uses the Java variable naming convention of sourceBranch vs SourceBranch. Hopefully this helps you out.
ElijahLynn
commented
6 years ago One caveat that we haven't figured out yet though is that when a build is pending, and you hover over the pending build to get information on it, the branch names are not in that info. However, if you go up a level and look at all pending jobs, the information is available.
omehegan
commented
6 years ago @azerbe can you confirm if you have this working now? I guess when I wrote the doc update I incorrectly assumed the variables could be overwritten, and that resulted in a broken example.
azerbe
commented
6 years ago Thanks for the replies. Kinda busy right now, but will look into it in the next days and give feedback.
azerbe
commented
6 years ago Okay, if you rename the String-Parameters and also the Branch Specifier and Branch to merge to blocks, it works.
Please also update the documentation, so that Branch Specifier and Branch to merge to are updated as well and everything is up to date again. :)
Please update #791
Thanks for the clarification guys!
omehegan
commented
6 years ago @azerbe and @ElijahLynn thanks for helping me improve the docs!
ElijahLynn
commented
6 years ago @azerbe Good catch, we do have the branch specifier and branch to merge AND "Calculate changelog against a specific branch" specified as well (ignore the casing in mine, we haven't changed it yet).
dastanko
commented
5 years ago Hi, guys does it also works for pipeline configuration? I followed instructions on readme and see that declared parameters override parameters coming from a web hook even though I applied the solution with Env.Inject.
devops-tavus
commented
1 year ago @dastanko were you able to do this for pipeline? I am facing the same problem.
Issue
Context
Logs & Traces
injectedEnvVars.txt (from EnvInject Plugin)
JenkinsJob config.xml
Jenkins Plugin-Log (after creating a new merge request)
Problem description
Before I've setup Gitlab, Jenkins, gitlab-plugin and a jenkins job (Freestyle, parameterized) following the documentation.
When I start the build by hand (From Jenkins) and insert branchnames into the parameter fields, everything is working fine.
When I create a merge-request or push a commit to the repository, the webhook triggers the build correctly, but the parameters that have been set in the configuration are empty. (
gitlabSourceBranchandgitlabTargetBranch) Every other parameter is working fine.Then the build fails, cause it can't pull.