Open thefirstofthe300 opened 5 years ago
omehegan
commented
5 years ago We recently began trying to configure the job triggers using the Jenkins DSL plugin
What is the Jenkins DSL plugin? Are you talking about the Job DSL plugin? If so, I don't understand why you are using that in this setup. Also, your before and after example configs are the same.
thefirstofthe300
commented
5 years ago Yes. I am referring to the Job DSL plugin. The automation setup we have going is as follows: our initial Jenkins setup loads a pipeline discovery automation script using Job DSL. This pipeline discovery script in turn scrapes our source code to discover our Jenkins pipelines and loads each pipeline using a standardized Job DSL template. Each pipeline is customized using the options/environment/triggers/etc set in the Jenkins file. In other words, we have things set up this way to maximize flexibility as much as possible while still making importing pipelines easy.
I also corrected the configs in my original post. The only change I made was to explicitly set the branchFilterType option to All despite branch filters not being used at all.
omehegan
commented
5 years ago This is probably happening because the plugin should set a default value for this parameter in code, but it doesn't bother because the value is normally set by default by the browser on the job config UI. Since Job DSL is generating a config, it is possible for default values to be unset. I don't have a lot of love for Job DSL for this and lots of other related reasons.
I think you could accomplish the same thing by using a properties step in your Jenkinsfiles to define the plugin settings as you want them. See https://github.com/jenkinsci/gitlab-plugin#pipeline-multibranch-jobs-1 This is only strictly necessary for Multibranch jobs, but IIRC it will work fine for regular Pipeline jobs as well, and will supersede whatever is set in the UI. This might be a more robust solution, and might simplify your Job DSL code. Let me know if this is helpful.
You would also benefit from #499, if we can get that done, so you don't need to use this pipeline discovery script.
Issue
Context
Logs & Traces
Problem description
Describe your problem in a meaningful way:
We are running a setup where Jenkins jobs are set up to be triggered by webhooks on a push to every branch in a repo. We recently began trying to configure the job triggers using the Jenkins DSL plugin to create a job where the triggers are configured in an SCM provided Jenkinsfile instead of configuring the triggers manually. When doing so, we ran into an issue where we would run the pipeline manually once to allow the job to pull in the trigger information.
Example trigger config:
The triggers would then show up as being configured in the web UI. When we pushed to the Github repo, the webhook would show up as having been received by Jenkins in the logs but the job itself had not triggered. After cranking up the debug logging as explained in the README, we stumbled upon the above NPE. Since the NPE appeared to be caused by a null BranchFilterConfig, I changed the triggers config to
and the Jenkins jobs were successfully triggered after running the job manually to pick up the new trigger config. I tried tracking down where the config type was not being set correctly but I'm not much good with Java. :\
The Gitlab webhook is configured as follows:
Let me know if you need any more info.