jenkinsci / gitlab-plugin

A Jenkins plugin for interfacing with GitLab
https://plugins.jenkins.io/gitlab-plugin/
GNU General Public License v2.0
1.44k stars 618 forks source link

GitLab plugin checks only global roles, project role is not verified #950

Open frluo opened 5 years ago

frluo commented 5 years ago

issue

Per plugin instruction document, I try to use userid+token for Jenkins job authentication: https://github.com/jenkinsci/gitlab-plugin#gitlab-to-jenkins-authentication, and use Configuring global authentication.

First, I grant the user with job/Build permission to certain jobs, e.g. grant permission to a folder which has several jobs. Second, I grant the user permission in global level, i.e. all jobs that has been assigned with job/Build permission.

After setting up above webhook in GitLab, and trigger the Job via GitLab, in the first scenario, the authentication is failed with code 403. and the second scenario is successful.

It seems GitLab plugin do not verify the folder level job/Build permission, instead, it checks only towards global job/Build permission.

Context

Logs & Traces

Error 403 xyz_user is missing the Job/Build permission

HTTP ERROR 403

Problem accessing /project/CTO/DevOps/sandbox/demo/test-global-role. Reason:

    xyz_user is missing the Job/Build permission


Powered by Jetty:// 9.4.z-SNAPSHOT

in Jenkins log: Jul 18, 2019 3:36:30 AM FINEST com.dabsquared.gitlabjenkins.webhook.build.BuildWebHookAction Unauthorized (Did you forget to add API Token to the web hook ?)

Problem description

Describe your problem in a meaningful way:

Fearxpc commented 5 years ago

+1 Facing the same problem. We manage all of our permissions on top level folders and don't want to set global permission Job/Build to all users.

I think the main problem is here in line 60 where the ACL is requested of the Jenkins instance only. https://github.com/jenkinsci/gitlab-plugin/blob/5b278e0613d14a96894570a58504a6acaba11687/src/main/java/com/dabsquared/gitlabjenkins/webhook/build/BuildWebHookAction.java#L58-L66

tobias-richter commented 4 years ago

+1 for this. I just run into this issue on a Jenkins 2.235.3 with Role-Based-Strategy. I have a user that has no global build rights but inside the folder.

Willem1987 commented 3 years ago

There seems to be a 1.5.17 sources release but no hpi? Is there any ETA on this?

Fearxpc commented 3 years ago

There seems to be a 1.5.17 sources release but no hpi? Is there any ETA on this?

Please check this issue: https://github.com/jenkinsci/gitlab-plugin/issues/1027

ghost commented 2 years ago

+1, I'm running Jenkins 2.303.3 and Gitlab Plugin 1.5.22 and I still have this issue. If people/groups don't have global Job/Build they are not able to build anything.

hudson.security.AccessDeniedException3: user.name is missing the Job/Build permission