search

jenkinsci / gogs-webhook-plugin

Jenkins Gogs Webhook
https://plugins.jenkins.io/gogs-webhook/
MIT License
78 stars 42 forks source link

Job not found in version 1.0.7 #4

Closed sanderv32 closed 7 years ago

sanderv32 commented 7 years ago

Silox:

Seems like this change broke something in the ?job=jobname query filter. In 1.0.7, testing the webhook from Gogs resulted in a 404: "Job X is not defined in Jenkins", downgrading to 1.0.6 fixed this error.

willemvd commented 7 years ago

Found the problem, it only occurs when you have setup authorization. When giving everybody all rights, the build will start. See we forgot to do the ACL stuff in this part, like we do in https://github.com/jenkinsci/gogs-webhook-plugin/blob/master/src/main/java/org/jenkinsci/plugins/gogs/GogsPayloadProcessor.java#L52-L53

I will create a new pull request to fix this

sanderv32 commented 7 years ago

Ok, thats nice that you have found it 👍 Will try to merge it tonight but i'm not able to test it.

nklmilojevic commented 7 years ago

Hi,

I'm also having the same problem with my Gogs and Jenkins. Hope that it'll be fixed soon.

willemvd commented 7 years ago

@sanderv32 you have merged #5 yesterday, but when will you release this?

sanderv32 commented 7 years ago

I hope to release it this evening.

sanderv32 commented 7 years ago

Just made release 1.0.8 with the fix @willemvd supplied. Now we'll have to wait before it's available in Jenkins.

nklmilojevic commented 7 years ago

Alright, everything works now. Thanks.

willemvd commented 7 years ago

@nklmilojevic agree 👍

sanderv32 commented 7 years ago

Thanks guys! I will close this issue. :-)

TomNaessens commented 7 years ago

Can confirm that it is fixed here too, thank you!

ilyasotkov commented 6 years ago

I have this issue with Gogs plugin 1.0.10. I use Gogs 0.11.29.0727 and Jenkins 2.84 . The response I get:

{"result":"ERROR","message":"Job << job name >>  is not defined in Jenkins"}
jmMeessen commented 6 years ago

Hello @ilyasotkov Thank you for reporting this. I will try to reproduce this and investigate.

For clarity, could you please open a separate issue for this.

/- Jmm

jmMeessen commented 6 years ago

Hello @ilyasotkov I was not able to reproduce your issue with Jenkins 2.84 and Gogs 0.11.29 (in the state available in the DockerHub images). I used for that the Automated Integration Tests I am working on.

When you have opened the adhoc ticket, can you describe what you try to achieve and how ?

/- Jmm