Feature/junit jupiter - Githubissues

jenkinsci / gogs-webhook-plugin

Jenkins Gogs Webhook

https://plugins.jenkins.io/gogs-webhook/

MIT License

79 stars 42 forks source link

Feature/junit jupiter #72

Closed nhojpatrick closed 2 years ago

nhojpatrick commented 2 years ago

JENKINS-xxxxx/PR-xxxx - summarize pull request in one line

Upgrade to Junit Jupiter, latest surefire/failsafe and improve checking for tests by using assertThrows

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have referenced the Jira/Github issue related to my changes in one or more commit messages
[ ] I have added tests that verify my changes
[ ] Unit tests pass locally with my changes
[ ] I have added documentation as necessary
[ ] No Javadoc warnings were introduced with my changes
[ ] No findbugs warnings were introduced with my changes
[ ] I have interactively tested my changes
[ ] Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Further comments

If this is a relatively large or complex change, start the discussion by explaining why you chose the solution you did and what alternatives you considered.

sanderv32 commented 2 years ago

Can you please resolve the conflict so that it can be merged?

nhojpatrick commented 2 years ago

Switching to draft to get PR #75 reviewed/merged 1st. Believe merge conflicts all sorted.