search

jenkinsci / google-chat-notification-plugin

Google Chat Notification Jenkins Plugin to send build status
https://plugins.jenkins.io/google-chat-notification/
MIT License
39 stars 20 forks source link

feat: Send notifications via proxy if globally configured #82

Closed coder-hugo closed 8 months ago

coder-hugo commented 8 months ago

This adds the functionality to use a globally configured proxy for sending the notifications. This was already implemented in earlier versions but seems to be removed during some refactoring. I haven't found a suitable way to implement tests for this feature, but I've deployed the SNAPSHOT of the plugin to our Jenkins instance to verify if the code is working. Our proxy doesn't require credentials so I can't tell, if the corresponding code is working as expected.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
Hungleminh commented 8 months ago

Hi @Ryudo302,

I had the same issue and thanks for bring it up. It seems like the notification not working via proxy now. And I would love to have the new version of this plugin to test this. Please kindly let me know if you have something new.

Ryudo302 commented 8 months ago

Hi @coder-hugo and @Hungleminh! A new version was released today with this feature. Thanks for the support! 😃

Hungleminh commented 8 months ago

Hi @Ryudo302 r It works OK now. Thanks for your great support!