Closed Artmorse closed 9 months ago
@BrianRossmajerAxonify @Vitorspk @bandi13 could you please try this change out and let us know whether this fixes the issue you were seeing (and you don't see anything else broken :)).
The release that contains this fix is https://github.com/jenkinsci/google-compute-engine-plugin/releases/tag/4.561.vfc075cc926e3.
Thank you very much!
At first glance, it looks like it fixes the issue I was seeing.
I didn't confirm that I could change the setting in the UI and see it saved properly; I might be able to test that tomorrow, but in the meantime it's looking much better -- very much appreciate your efforts!
Awesome, thanks for confirming!
Can confirm this has been fixed.
This PR wants to fix the issue #438 introduced in #434.
Reproduction steps:
Fix
The issue came from the
readResolve
method. Each time we saved the configuration we passed in thereadResolve
method which reset thenetworkInterfaceIpStackMode
toNetworkInterfaceSingleStack(externalAddress)
. I set theexternalAddress
as a primitiveBoolean
and I added a condition in thereadResolve
to set this value tonull
after the first time we reach it.Testing done